Issue 2388903002: Remove redundant code from ChromeApplication.

Issue 2388903002: Remove redundant code from ChromeApplication. (Closed)

Created:
4 years, 2 months ago by estevenson

Modified:
4 years, 2 months ago

Reviewers:
Ted C

CC:
chromium-reviews, agrieve+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Remove redundant code from ChromeApplication. BUG=560466 Committed: https://crrev.com/1ce1d1062685ad5e20ac496a0fb525a33baa4f1e Cr-Commit-Position: refs/heads/master@{#422503}

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -45 lines)			Patch
	M	chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java	View		4 chunks	+4 lines, -4 lines	0 comments	Download
	M	chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java	View		6 chunks	+0 lines, -41 lines	0 comments	Download

Total messages: 12 (7 generated)

estevenson

ptal Ted! Looks like showSingleOriginSettings was added in https://codereview.chromium.org/927763003 but never actually used.

4 years, 2 months ago (2016-10-03 19:33:15 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388903002/1

4 years, 2 months ago (2016-10-03 19:59:12 UTC) #9

commit-bot: I haz the power

4 years, 2 months ago (2016-10-03 20:07:05 UTC) #12

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/1ce1d1062685ad5e20ac496a0fb525a33baa4f1e
Cr-Commit-Position: refs/heads/master@{#422503}