Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java

Issue 2388903002: Remove redundant code from ChromeApplication. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
index f59ebbe1ebbb4b00cccb7e63241398a8136cc387..04fcc20a57f935529e4efe45fab93877d575006b 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java
@@ -7,7 +7,6 @@ package org.chromium.chrome.browser;
import android.app.Activity;
import android.content.Intent;
import android.content.SharedPreferences;
-import android.os.Bundle;
import android.os.Handler;
import android.os.Looper;
import android.os.SystemClock;
@@ -48,12 +47,10 @@ import org.chromium.chrome.browser.physicalweb.PhysicalWebBleClient;
import org.chromium.chrome.browser.physicalweb.PhysicalWebEnvironment;
import org.chromium.chrome.browser.policy.PolicyAuditor;
import org.chromium.chrome.browser.preferences.LocationSettings;
-import org.chromium.chrome.browser.preferences.Preferences;
import org.chromium.chrome.browser.preferences.PreferencesLauncher;
import org.chromium.chrome.browser.preferences.autofill.AutofillPreferences;
import org.chromium.chrome.browser.preferences.password.SavePasswordsPreferences;
import org.chromium.chrome.browser.preferences.privacy.ClearBrowsingDataPreferences;
-import org.chromium.chrome.browser.preferences.website.SingleWebsitePreferences;
import org.chromium.chrome.browser.printing.PrintingControllerFactory;
import org.chromium.chrome.browser.rlz.RevenueStats;
import org.chromium.chrome.browser.services.AndroidEduOwnerCheckCallback;
@@ -71,9 +68,7 @@ import org.chromium.content.app.ContentApplication;
import org.chromium.content.browser.ChildProcessCreationParams;
import org.chromium.policy.AppRestrictionsProvider;
import org.chromium.policy.CombinedPolicyProvider;
-import org.chromium.policy.CombinedPolicyProvider.PolicyChangeListener;
import org.chromium.printing.PrintingController;
-import org.chromium.ui.base.ActivityWindowAndroid;
import org.chromium.ui.base.ResourceBundle;
/**
@@ -163,20 +158,6 @@ public class ChromeApplication extends ContentApplication {
SavePasswordsPreferences.class.getName());
}
- /**
- * Opens the single origin settings page for the given URL.
- *
- * @param url The URL to show the single origin settings for. This is a complete url
- * including scheme, domain, port, path, etc.
- */
- protected void showSingleOriginSettings(String url) {
- Bundle fragmentArgs = SingleWebsitePreferences.createFragmentArgsForSite(url);
- Intent intent = PreferencesLauncher.createIntentForSettingsPage(
- this, SingleWebsitePreferences.class.getName());
- intent.putExtra(Preferences.EXTRA_SHOW_FRAGMENT_ARGUMENTS, fragmentArgs);
- startActivity(intent);
- }
-
@Override
protected void initializeLibraryDependencies() {
// The ResourceExtractor is only needed by the browser process, but this will have no
@@ -325,14 +306,6 @@ public class ChromeApplication extends ContentApplication {
}
/**
- * @return A new ActivityWindowAndroid instance.
- */
- public ActivityWindowAndroid createActivityWindowAndroid(Activity activity) {
- if (activity instanceof ChromeActivity) return new ChromeWindow((ChromeActivity) activity);
- return new ActivityWindowAndroid(activity);
- }
-
- /**
* @return An instance of {@link CustomTabsConnection}. Should not be called
* outside of {@link CustomTabsConnection#getInstance()}.
*/
@@ -397,20 +370,6 @@ public class ChromeApplication extends ContentApplication {
}
/**
- * Add a listener to be notified upon policy changes.
- */
- public void addPolicyChangeListener(PolicyChangeListener listener) {
- CombinedPolicyProvider.get().addPolicyChangeListener(listener);
- }
-
- /**
- * Remove a listener to be notified upon policy changes.
- */
- public void removePolicyChangeListener(PolicyChangeListener listener) {
- CombinedPolicyProvider.get().removePolicyChangeListener(listener);
- }
-
- /**
* @return An instance of PolicyAuditor that notifies the policy system of the user's activity.
* Only applicable when the user has a policy active, that is tracking the activity.
*/
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698