Issue 2388893002: Show tooltips in SHELF_AUTO_HIDE ShelfVisibilityState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2388893002: Show tooltips in SHELF_AUTO_HIDE ShelfVisibilityState. (Closed)

Created:
4 years, 2 months ago by msw

Modified:
4 years, 2 months ago

Reviewers:
James Cook

CC:
chromium-reviews

Target Ref:
refs/pending/branch-heads/2840

Project:
chromium

Visibility:
Public.

Show tooltips in SHELF_AUTO_HIDE ShelfVisibilityState. Tooltips should show when the auto-hidden shelf is exposed. Regressed in https://codereview.chromium.org/2176813002 BUG=651645 TEST=Shelf shows tooltips in auto-hide state; see bug. R=jamescook@chromium.org Review-Url: https://codereview.chromium.org/2383833003 Cr-Commit-Position: refs/heads/master@{#422190} (cherry picked from commit 87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc) Committed: https://chromium.googlesource.com/chromium/src/+/c1f39367d86d336f97ff7c0b54f6e98bf16569b2

Created: 4 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -4 lines)			Patch
	M	ash/common/shelf/shelf_tooltip_manager.cc	View		1 chunk	+5 lines, -2 lines	0 comments	Download
	M	ash/common/shelf/shelf_tooltip_manager_unittest.cc	View		2 chunks	+19 lines, -2 lines	0 comments	Download

Total messages: 2 (1 generated)

msw

4 years, 2 months ago (2016-10-03 18:13:48 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c1f39367d86d336f97ff7c0b54f6e98bf16569b2.