Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2383833003: Show tooltips in SHELF_AUTO_HIDE ShelfVisibilityState. (Closed)

Created:
4 years, 2 months ago by msw
Modified:
4 years, 2 months ago
Reviewers:
James Cook
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Show tooltips in SHELF_AUTO_HIDE ShelfVisibilityState. Tooltips should show when the auto-hidden shelf is exposed. Regressed in https://codereview.chromium.org/2176813002 BUG=651645 TEST=Shelf shows tooltips in auto-hide state; see bug. R=jamescook@chromium.org Committed: https://crrev.com/87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc Cr-Commit-Position: refs/heads/master@{#422190}

Patch Set 1 #

Patch Set 2 : Fix auto-hide shown and hidden behavior; fix tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M ash/common/shelf/shelf_tooltip_manager.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download
M ash/common/shelf/shelf_tooltip_manager_unittest.cc View 1 2 chunks +19 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
msw
Hey James, please take a look; thanks!
4 years, 2 months ago (2016-09-30 18:20:12 UTC) #1
msw
Sorry, hold off a minute while I update tests...
4 years, 2 months ago (2016-09-30 18:28:59 UTC) #2
msw
Okay, please take a look now; thanks!
4 years, 2 months ago (2016-09-30 19:00:14 UTC) #4
James Cook
LGTM
4 years, 2 months ago (2016-09-30 19:07:00 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2383833003/20001
4 years, 2 months ago (2016-09-30 19:41:59 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-30 19:48:30 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-30 19:50:47 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/87ee8b86123d1ecf3f9d458ccf92674d3e7b75fc
Cr-Commit-Position: refs/heads/master@{#422190}

Powered by Google App Engine
This is Rietveld 408576698