Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java

Issue 2388783004: Ensure PopularSite icon availability in ntp_tiles. (Closed)
Patch Set: Merge branch 'master' into icons Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
index 86835092624397ae5ee099719ebca29a5b38a5be..04a22c1e07de284a30a27027bfc5a0a43432c5fe 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java
@@ -31,15 +31,13 @@ public class MostVisitedSites {
String[] whitelistIconPaths, int[] sources);
/**
- * This is called when the list of popular URLs is initially available or updated.
+ * This is called when a previously uncached icon has been fetched.
* Parameters guaranteed to be non-null.
*
- * @param urls Array of popular URLs.
- * @param faviconUrls Array of URLs for the corresponding favicons (if known).
+ * @param siteUrl URL of site with newly-cached icon.
*/
@CalledByNative("MostVisitedURLsObserver")
- public void onPopularURLsAvailable(
- String[] urls, String[] faviconUrls, String[] largeIconUrls);
+ public void onIconMadeAvailable(String siteUrl);
}
/**
@@ -80,11 +78,10 @@ public class MostVisitedSites {
}
}
@Override
- public void onPopularURLsAvailable(
- String[] urls, String[] faviconUrls, String[] largeIconUrls) {
+ public void onIconMadeAvailable(String siteUrl) {
// Don't notify observer if we've already been destroyed.
if (mNativeMostVisitedSitesBridge != 0) {
- observer.onPopularURLsAvailable(urls, faviconUrls, largeIconUrls);
+ observer.onIconMadeAvailable(siteUrl);
}
}
};

Powered by Google App Engine
This is Rietveld 408576698