Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4193)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2388783004: Ensure PopularSite icon availability in ntp_tiles. (Closed)
Patch Set: Merge branch 'master' into icons Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index 0d88cb80875d97002a5a448b316f8ed6d359338b..275444fc886474b629b1ca3fb53dbbe490a5e56c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -1047,27 +1047,8 @@ public class NewTabPageView extends FrameLayout
}
@Override
- public void onPopularURLsAvailable(
- String[] urls, String[] faviconUrls, String[] largeIconUrls) {
- for (int i = 0; i < urls.length; i++) {
- final String url = urls[i];
- boolean useLargeIcon = !largeIconUrls[i].isEmpty();
- // Only fetch one of favicon or large icon based on what is required on the NTP.
- // The other will be fetched on visiting the site.
- String iconUrl = useLargeIcon ? largeIconUrls[i] : faviconUrls[i];
- if (iconUrl.isEmpty()) continue;
-
- IconAvailabilityCallback callback = new IconAvailabilityCallback() {
- @Override
- public void onIconAvailabilityChecked(boolean newlyAvailable) {
- if (newlyAvailable) {
- mMostVisitedDesign.onIconUpdated(url);
- }
- }
- };
- mManager.ensureIconIsAvailable(
- url, iconUrl, useLargeIcon, /*isTemporary=*/false, callback);
- }
+ public void onIconMadeAvailable(String siteUrl) {
+ mMostVisitedDesign.onIconUpdated(siteUrl);
}
/**
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/profiles/MostVisitedSites.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698