Make DragCaretController store PositionWithAffinity instead of VisiblePosition

Make DragCaretController store PositionWithAffinity instead of VisiblePosition

DragCaretController is an on-stack object that stores a VisiblePosition and may
inspect properties of the VisiblePosition even after it is invalidated. This
patch fixes it by making DragCaretController store a PositionWithAffinity
instead.

This patch is a preparation of pruning createVisibleSelectionDeprecated from
DragController: https://codereview.chromium.org/2386083002

BUG=648949, 651373
Committed: https://crrev.com/0895689a9cf3613ea07cd1a05ce4c6d32d6d411c
Cr-Commit-Position: refs/heads/master@{#422395}

[Xiaocheng, 2016-10-03 07:15:39]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 07:15:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Xiaocheng, 2016-10-03 07:46:21]

Description was changed from

==========
Make DragCaretController store PositionWithAffinity instead of VisiblePosition

BUG=648949,651373
==========

to

==========
Make DragCaretController store PositionWithAffinity instead of VisiblePosition

DragCaretController is an on-stack object that stores a VisiblePosition and may
inspect properties of the VisiblePosition even after it is invalidated. This
patch fixes it by making DragCaretController store a PositionWithAffinity
instead.

This patch is a preparation of pruning createVisibleSelectionDeprecated from
DragController: https://codereview.chromium.org/2386083002

BUG=648949,651373
==========

[Xiaocheng, 2016-10-03 08:14:59]

xiaochengh@chromium.org changed reviewers:
+ yosin@chromium.org

[Xiaocheng, 2016-10-03 08:14:59]

PTAL.

By this patch we can eliminate one source of invalid VP.

[commit-bot: I haz the power, 2016-10-03 08:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 08:32:54]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2016-10-03 09:26:53]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2016-10-03 09:26:54]

lgtm

lgtm

This patch is also a preparation of http://crrev.com/1958093002, Postpone
visible canonicalization for FrameSelection.

[commit-bot: I haz the power, 2016-10-03 09:27:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 09:32:29]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-03 09:34:42]

Description was changed from

==========
Make DragCaretController store PositionWithAffinity instead of VisiblePosition

DragCaretController is an on-stack object that stores a VisiblePosition and may
inspect properties of the VisiblePosition even after it is invalidated. This
patch fixes it by making DragCaretController store a PositionWithAffinity
instead.

This patch is a preparation of pruning createVisibleSelectionDeprecated from
DragController: https://codereview.chromium.org/2386083002

BUG=648949,651373
==========

to

==========
Make DragCaretController store PositionWithAffinity instead of VisiblePosition

DragCaretController is an on-stack object that stores a VisiblePosition and may
inspect properties of the VisiblePosition even after it is invalidated. This
patch fixes it by making DragCaretController store a PositionWithAffinity
instead.

This patch is a preparation of pruning createVisibleSelectionDeprecated from
DragController: https://codereview.chromium.org/2386083002

BUG=648949,651373

Committed: https://crrev.com/0895689a9cf3613ea07cd1a05ce4c6d32d6d411c
Cr-Commit-Position: refs/heads/master@{#422395}
==========

[commit-bot: I haz the power, 2016-10-03 09:34:43]

Patchset 1 (id:??) landed as
https://crrev.com/0895689a9cf3613ea07cd1a05ce4c6d32d6d411c
Cr-Commit-Position: refs/heads/master@{#422395}