Prune createVisibleSelectionDeprecated from DragController

Prune createVisibleSelectionDeprecated from DragController

This patch prunes createVisibleSelectionDeprecated from DragController
by either having an explicit layout update before each call site, or
confirming that the layout is already clean.

Note: Layout is clean at the call site in |dispatchTextInputEventFor()|
because it's called directly after a hit test, which is performed in
|elementUnderMouse()|.

BUG=651373
Committed: https://crrev.com/4e348b48e7e058f44d359263b750bb5412ab932a
Cr-Commit-Position: refs/heads/master@{#423036}

[Xiaocheng, 2016-10-03 07:31:24]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-03 07:31:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 08:45:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-03 08:45:39]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-03 09:31:40]

xiaochengh@chromium.org changed reviewers:
+ tkent@chromium.org

[Xiaocheng, 2016-10-03 09:31:41]

PTAL.

[tkent, 2016-10-03 23:37:09]

https://codereview.chromium.org/2386083002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/DragController.cpp (right):

https://codereview.chromium.org/2386083002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/DragController.cpp:482:
createVisibleSelection(m_page->dragCaretController().caretPosition()));
Please explain why we can use non-deprecated version in the CL description. 
It's not obvious.

[Xiaocheng, 2016-10-04 01:07:51]

Description was changed from

==========
Prune createVisibleSelectionDeprecated from DragController

BUG=651373
==========

to

==========
Prune createVisibleSelectionDeprecated from DragController

This patch prunes createVisibleSelectionDeprecated from DragController
by either having an explicit layout update before each call site, or
confirming that the layout is already clean.

Note: Layout is clean at the call site in |dispatchTextInputEventFor()|
because it's called directly after a hit test, which is performed in
|elementUnderMouse()|.

BUG=651373
==========

[Xiaocheng, 2016-10-04 01:07:58]

On 2016/10/03 at 23:37:09, tkent wrote:
>
https://codereview.chromium.org/2386083002/diff/1/third_party/WebKit/Source/c...
> File third_party/WebKit/Source/core/page/DragController.cpp (right):
> 
>
https://codereview.chromium.org/2386083002/diff/1/third_party/WebKit/Source/c...
> third_party/WebKit/Source/core/page/DragController.cpp:482:
createVisibleSelection(m_page->dragCaretController().caretPosition()));
> Please explain why we can use non-deprecated version in the CL description. 
It's not obvious.

Done.

[tkent, 2016-10-04 01:25:12]

On 2016/10/04 at 01:07:58, xiaochengh wrote:
> On 2016/10/03 at 23:37:09, tkent wrote:
> >
https://codereview.chromium.org/2386083002/diff/1/third_party/WebKit/Source/c...
> > File third_party/WebKit/Source/core/page/DragController.cpp (right):
> > 
> >
https://codereview.chromium.org/2386083002/diff/1/third_party/WebKit/Source/c...
> > third_party/WebKit/Source/core/page/DragController.cpp:482:
createVisibleSelection(m_page->dragCaretController().caretPosition()));
> > Please explain why we can use non-deprecated version in the CL description. 
It's not obvious.
> 
> Done.

Please add DCHEK for clean layout, and/or a comment about clean layout
requirement to DragController::dispatchTextInputEventFor() in order to prevent
people from adding dirty layout callsites.

[Xiaocheng, 2016-10-04 06:54:02]

On 2016/10/04 at 01:25:12, tkent wrote:
> On 2016/10/04 at 01:07:58, xiaochengh wrote:
> > On 2016/10/03 at 23:37:09, tkent wrote:
> > >
https://codereview.chromium.org/2386083002/diff/1/third_party/WebKit/Source/c...
> > > File third_party/WebKit/Source/core/page/DragController.cpp (right):
> > > 
> > >
https://codereview.chromium.org/2386083002/diff/1/third_party/WebKit/Source/c...
> > > third_party/WebKit/Source/core/page/DragController.cpp:482:
createVisibleSelection(m_page->dragCaretController().caretPosition()));
> > > Please explain why we can use non-deprecated version in the CL
description.  It's not obvious.
> > 
> > Done.
> 
> Please add DCHEK for clean layout, and/or a comment about clean layout
requirement to DragController::dispatchTextInputEventFor() in order to prevent
people from adding dirty layout callsites.

DragController.cpp mostly uses ASSERT instead of DCHECK. Is there a reason?

[tkent, 2016-10-04 07:17:02]

> DragController.cpp mostly uses ASSERT instead of DCHECK. Is there a reason?

No one replaces ASSERTs with DECHEKs yet.  We don't add new ASSERTs.

[Xiaocheng, 2016-10-04 08:59:56]

The CQ bit was checked by xiaochengh@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 09:00:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-04 10:22:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 10:22:04]

Dry run: This issue passed the CQ dry run.

[Xiaocheng, 2016-10-04 23:48:39]

DCHECK added. PTAL.

[tkent, 2016-10-05 00:08:44]

lgtm

[Xiaocheng, 2016-10-05 01:17:13]

The CQ bit was checked by xiaochengh@chromium.org

[commit-bot: I haz the power, 2016-10-05 01:17:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 01:23:19]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-05 01:26:37]

Description was changed from

==========
Prune createVisibleSelectionDeprecated from DragController

This patch prunes createVisibleSelectionDeprecated from DragController
by either having an explicit layout update before each call site, or
confirming that the layout is already clean.

Note: Layout is clean at the call site in |dispatchTextInputEventFor()|
because it's called directly after a hit test, which is performed in
|elementUnderMouse()|.

BUG=651373
==========

to

==========
Prune createVisibleSelectionDeprecated from DragController

This patch prunes createVisibleSelectionDeprecated from DragController
by either having an explicit layout update before each call site, or
confirming that the layout is already clean.

Note: Layout is clean at the call site in |dispatchTextInputEventFor()|
because it's called directly after a hit test, which is performed in
|elementUnderMouse()|.

BUG=651373

Committed: https://crrev.com/4e348b48e7e058f44d359263b750bb5412ab932a
Cr-Commit-Position: refs/heads/master@{#423036}
==========

[commit-bot: I haz the power, 2016-10-05 01:26:38]

Patchset 2 (id:??) landed as
https://crrev.com/4e348b48e7e058f44d359263b750bb5412ab932a
Cr-Commit-Position: refs/heads/master@{#423036}