Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(785)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.h

Issue 2388613002: Move below headers even when row doesn't require a strut (Closed)
Patch Set: bug 642814 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.h b/third_party/WebKit/Source/core/layout/LayoutTableSection.h
index 354654ba43718745c260302d2d579188df3eef80..b0835dde30d618f5abc2ff6cddeecf02fd2a461a 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.h
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.h
@@ -26,6 +26,7 @@
#define LayoutTableSection_h
#include "core/CoreExport.h"
+#include "core/layout/LayoutState.h"
#include "core/layout/LayoutTable.h"
#include "core/layout/LayoutTableBoxComponent.h"
#include "wtf/Vector.h"
@@ -312,6 +313,13 @@ class CORE_EXPORT LayoutTableSection final : public LayoutTableBoxComponent {
}
int paginationStrutForRow(LayoutTableRow*, LayoutUnit logicalOffset) const;
+ bool needsStrutForTableHeaders(const LayoutState& state,
mstensho (USE GERRIT) 2016/10/04 21:02:38 I think I'd non-inline this, and skip the LayoutSt
+ LayoutUnit logicalOffset) {
+ return state.heightOffsetForTableHeaders() &&
+ (pageRemainingLogicalHeightForOffset(
mstensho (USE GERRIT) 2016/10/04 21:02:38 Expression doesn't need to be in parentheses. (Ma
rhogan 2016/10/04 21:10:45 God it's awful.
+ logicalOffset, LayoutBlock::AssociateWithLatterPage) ==
mstensho (USE GERRIT) 2016/10/04 21:02:38 AssociateWithLatterPage is defined in LayoutBox, s
+ pageLogicalHeightForOffset(logicalOffset));
+ };
void setOffsetForRepeatingHeader(LayoutUnit offset) {
m_offsetForRepeatingHeader = offset;

Powered by Google App Engine
This is Rietveld 408576698