Move below headers even when row doesn't require a strut

third_party/WebKit/Source/core/layout/LayoutTableSection.h

 /*
  * Copyright (C) 1997 Martin Jones (mjones@kde.org)
  *           (C) 1997 Torben Weis (weis@kde.org)
  *           (C) 1998 Waldo Bastian (bastian@kde.org)
  *           (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2003, 2004, 2005, 2006, 2009, 2013 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
  * Library General Public License for more details.
  *
  * You should have received a copy of the GNU Library General Public License
  * along with this library; see the file COPYING.LIB.  If not, write to
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  */
 
 #ifndef LayoutTableSection_h
 #define LayoutTableSection_h
 
 #include "core/CoreExport.h"
+#include "core/layout/LayoutState.h"
 #include "core/layout/LayoutTable.h"
 #include "core/layout/LayoutTableBoxComponent.h"
 #include "wtf/Vector.h"
 
 namespace blink {
 
 // This variable is used to balance the memory consumption vs the paint invalidation time on big tables.
 const float gMaxAllowedOverflowingCellRatioForFastPaintPath = 0.1f;
 
 // Helper class for paintObject.
@@ skipping 266 matching lines @@
   // For simplicity, just conservatively assume all table sections are not opaque.
   bool foregroundIsKnownToBeOpaqueInRect(const LayoutRect&,
                                          unsigned) const override {
     return false;
   }
   bool backgroundIsKnownToBeOpaqueInRect(const LayoutRect&) const override {
     return false;
   }
 
   int paginationStrutForRow(LayoutTableRow*, LayoutUnit logicalOffset) const;
+  bool needsStrutForTableHeaders(const LayoutState& state,

[mstensho (USE GERRIT), 2016/10/04 21:02:38]

I think I'd non-inline this, and skip the LayoutState parameter.

+                                 LayoutUnit logicalOffset) {
+    return state.heightOffsetForTableHeaders() &&
+           (pageRemainingLogicalHeightForOffset(

[mstensho (USE GERRIT), 2016/10/04 21:02:38]

Expression doesn't need to be in parentheses.

(Man, this 80 cols limit makes code hard to read sometimes) :(

[rhogan, 2016/10/04 21:10:45]

God it's awful.

+                logicalOffset, LayoutBlock::AssociateWithLatterPage) ==

[mstensho (USE GERRIT), 2016/10/04 21:02:38]

AssociateWithLatterPage is defined in LayoutBox, so no need to prefix it with a
scope.

+            pageLogicalHeightForOffset(logicalOffset));
+  };
 
   void setOffsetForRepeatingHeader(LayoutUnit offset) {
     m_offsetForRepeatingHeader = offset;
   }
   LayoutUnit offsetForRepeatingHeader() const {
     return m_offsetForRepeatingHeader;
   }
 
   bool mapToVisualRectInAncestorSpace(
       const LayoutBoxModelObject* ancestor,
@@ skipping 131 matching lines @@
   bool m_hasMultipleCellLevels;
 
   LayoutUnit m_offsetForRepeatingHeader;
 };
 
 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutTableSection, isTableSection());
 
 }  // namespace blink
 
 #endif  // LayoutTableSection_h