Source/core/page/DragController.cpp - Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/page/DragController.cpp

Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix tests build Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/page/DragController.cpp

diff --git a/Source/core/page/DragController.cpp b/Source/core/page/DragController.cpp

index edbd8955222eea7973a2d854fc2dd3f1ddb0bce1..307b2b687d08005b0b8bdb6d14bfc2ac3d00b7ec 100644

--- a/Source/core/page/DragController.cpp

+++ b/Source/core/page/DragController.cpp

@@ -159,7 +159,7 @@ static PassRefPtr<DocumentFragment> documentFragmentFromDragData(DragData* dragD

String title;

String url = dragData->asURL(frame, DragData::DoNotConvertFilenames, &title);

if (!url.isEmpty()) {

- RefPtr<HTMLAnchorElement> anchor = HTMLAnchorElement::create(document);

+ RefPtr<HTMLAnchorElement> anchor = HTMLAnchorElement::create(*document);

anchor->setHref(url);

if (title.isEmpty()) {

// Try the plain text first because the url might be normalized or escaped.

« no previous file with comments | « Source/core/html/track/TextTrackCueGeneric.cpp ('k') | Source/core/page/ImageBitmapTest.cpp » ('j') | Source/core/svg/SVGElement.h » ('J')