Source/core/svg/SVGElement.h - Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGElement.h

Issue 23886003: Have HTMLElements / SVGElements constructors take a Document reference in argument (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Fix tests build Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/svg/SVGElement.h

diff --git a/Source/core/svg/SVGElement.h b/Source/core/svg/SVGElement.h

index e493ab2ce42e86aa3762b6552069de0f8d4aec99..2df07e88c169d53475f058bad74681a6c9a84ee2 100644

--- a/Source/core/svg/SVGElement.h

+++ b/Source/core/svg/SVGElement.h

@@ -48,7 +48,6 @@ void mapAttributeToCSSProperty(HashMap<StringImpl*, CSSPropertyID>* propertyName

class SVGElement : public Element, public SVGLangSpace {

public:

- static PassRefPtr<SVGElement> create(const QualifiedName&, Document*);

tkent 2013/09/03 12:53:09 Don't we need this?

do-not-use 2013/09/03 12:59:42 Not anymore. It used to be needed to construct unk

virtual ~SVGElement();

bool isOutermostSVGSVGElement() const;

@@ -135,7 +134,7 @@ public:

virtual bool shouldMoveToFlowThread(RenderStyle*) const OVERRIDE;

protected:

- SVGElement(const QualifiedName&, Document*, ConstructionType = CreateSVGElement);

+ SVGElement(const QualifiedName&, Document&, ConstructionType = CreateSVGElement);

virtual void parseAttribute(const QualifiedName&, const AtomicString&) OVERRIDE;

« no previous file with comments | « Source/core/svg/SVGDescElement.cpp ('k') | Source/core/svg/SVGElement.cpp » ('j') | no next file with comments »