Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 23883005: Prefix endure test names. (Closed)

Created:
7 years, 3 months ago by Michael Achenbach
Modified:
7 years, 3 months ago
Reviewers:
agable
CC:
chromium-reviews, cmp-cc_chromium.org, ilevy-cc_chromium.org, xusydoc+watch_chromium.org, kjellander+cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build@master
Visibility:
Public.

Description

Prefix endure test names. CL https://codereview.chromium.org/23625005/ introduced too short names for endure tests, since the step name is used globally on the dashboard as the test id. This CL prefixes all endure tests with endure_ and adds also a suffix to some tests for better distinction in the future. CL https://codereview.chromium.org/23503041/ will be updated after this one lands. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=222000

Patch Set 1 #

Total comments: 1

Patch Set 2 : Addressed review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M scripts/master/factory/chromium_factory.py View 1 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
PTAL
7 years, 3 months ago (2013-09-09 09:44:40 UTC) #1
agable
lgtm % naming nit https://codereview.chromium.org/23883005/diff/1/scripts/master/factory/chromium_factory.py File scripts/master/factory/chromium_factory.py (right): https://codereview.chromium.org/23883005/diff/1/scripts/master/factory/chromium_factory.py#newcode900 scripts/master/factory/chromium_factory.py:900: step_name='endure_cal_for_back', factory_properties=fp, "fw" is a ...
7 years, 3 months ago (2013-09-09 10:36:40 UTC) #2
Michael Achenbach
On 2013/09/09 10:36:40, Aaron Gable wrote: > lgtm % naming nit > > https://codereview.chromium.org/23883005/diff/1/scripts/master/factory/chromium_factory.py > ...
7 years, 3 months ago (2013-09-09 10:42:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/machenbach@chromium.org/23883005/5001
7 years, 3 months ago (2013-09-09 10:42:32 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-09 10:43:23 UTC) #5
Message was sent while issue was closed.
Change committed as 222000

Powered by Google App Engine
This is Rietveld 408576698