Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h

Issue 2388293002: Disable GPU acceleration on 2D canvas when readbacks are needed (Closed)
Patch Set: fixed tests Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
diff --git a/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h b/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
index b1b2d4a20d7c1696bf9f2e342667ee1c23a660a3..f50b5e06a76496184aeb18132b7c4d41ca92df1f 100644
--- a/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
+++ b/third_party/WebKit/Source/platform/graphics/ExpensiveCanvasHeuristicParameters.h
@@ -67,6 +67,13 @@ enum {
GetImageDataForcesNoAcceleration = 1,
+ // Whan a canvas is used as a source image, if its destination is
+ // non-accelerated and the source canvas is accelerated, a readback
+ // from the gpu is necessary. This option cause the source canvas to
Stephen White 2016/10/04 18:40:14 Nit: cause -> causes
+ // switch to non-accelerated when this situation is encountered to
+ // prevent future canvas to canvas draws from requiring a readback.
Stephen White 2016/10/04 18:40:14 uNit: "canvas to canvas" -> "canvas-to-canvas"
+ DisableAccelerationToAvoidReadbacks = 1,
+
// When drawing very large images to canvases, there is a point where
// GPU acceleration becomes inefficient due to texture upload overhead,
// especially when the image is large enough that it is likely to
« no previous file with comments | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DTest.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698