third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp - Issue 2388193002: Reflow comments in modules/peerconnection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp

Issue 2388193002: Reflow comments in modules/peerconnection. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/peerconnection/RTCStatsResponse.cpp ('k') | third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestPromiseImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp

diff --git a/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp b/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp

index d5afba4efaffc42fef95e46f543005b8f8d7a86c..9b85f7a7521ca9a217dd49c0bc6ce3771375d000 100644

--- a/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp

+++ b/third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp

@@ -76,7 +76,8 @@ void RTCVoidRequestImpl::requestFailed(const String& error) {

bool shouldFireCallback =

m_requester && m_requester->shouldFireDefaultCallbacks();

if (shouldFireCallback && m_errorCallback.get()) {

- // TODO(guidou): The error code should come from the content layer. See crbug.com/589455

+ // TODO(guidou): The error code should come from the content layer. See

+ // crbug.com/589455

m_errorCallback->handleEvent(DOMException::create(OperationError, error));

}