Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Side by Side Diff: third_party/WebKit/Source/modules/peerconnection/RTCVoidRequestImpl.cpp

Issue 2388193002: Reflow comments in modules/peerconnection. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
69 if (shouldFireCallback && m_successCallback) 69 if (shouldFireCallback && m_successCallback)
70 m_successCallback->handleEvent(); 70 m_successCallback->handleEvent();
71 71
72 clear(); 72 clear();
73 } 73 }
74 74
75 void RTCVoidRequestImpl::requestFailed(const String& error) { 75 void RTCVoidRequestImpl::requestFailed(const String& error) {
76 bool shouldFireCallback = 76 bool shouldFireCallback =
77 m_requester && m_requester->shouldFireDefaultCallbacks(); 77 m_requester && m_requester->shouldFireDefaultCallbacks();
78 if (shouldFireCallback && m_errorCallback.get()) { 78 if (shouldFireCallback && m_errorCallback.get()) {
79 // TODO(guidou): The error code should come from the content layer. See crbu g.com/589455 79 // TODO(guidou): The error code should come from the content layer. See
80 // crbug.com/589455
80 m_errorCallback->handleEvent(DOMException::create(OperationError, error)); 81 m_errorCallback->handleEvent(DOMException::create(OperationError, error));
81 } 82 }
82 83
83 clear(); 84 clear();
84 } 85 }
85 86
86 void RTCVoidRequestImpl::stop() { 87 void RTCVoidRequestImpl::stop() {
87 clear(); 88 clear();
88 } 89 }
89 90
90 void RTCVoidRequestImpl::clear() { 91 void RTCVoidRequestImpl::clear() {
91 m_successCallback.clear(); 92 m_successCallback.clear();
92 m_errorCallback.clear(); 93 m_errorCallback.clear();
93 m_requester.clear(); 94 m_requester.clear();
94 } 95 }
95 96
96 DEFINE_TRACE(RTCVoidRequestImpl) { 97 DEFINE_TRACE(RTCVoidRequestImpl) {
97 visitor->trace(m_successCallback); 98 visitor->trace(m_successCallback);
98 visitor->trace(m_errorCallback); 99 visitor->trace(m_errorCallback);
99 visitor->trace(m_requester); 100 visitor->trace(m_requester);
100 RTCVoidRequest::trace(visitor); 101 RTCVoidRequest::trace(visitor);
101 ActiveDOMObject::trace(visitor); 102 ActiveDOMObject::trace(visitor);
102 } 103 }
103 104
104 } // namespace blink 105 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698