Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2085)

Unified Diff: build/config/mac/compile_xib.py

Issue 2388063003: Add a variable use_system_xcode to GN. (Closed)
Patch Set: Comments from dpranke. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/mac/compile_xib.py
diff --git a/build/config/mac/compile_xib.py b/build/config/mac/compile_xib.py
index 845f8c179550bbd339cbd306a008671cf8573607..f37ab2d69d5c816ec4858dfdce682b78997674d3 100644
--- a/build/config/mac/compile_xib.py
+++ b/build/config/mac/compile_xib.py
@@ -4,6 +4,7 @@
import argparse
+import logging
import os
import re
import subprocess
@@ -18,8 +19,13 @@ def main():
help='Path to output bundle.')
parser.add_argument('-i', '--input', required=True,
help='Path to input xib or storyboard.')
+ parser.add_argument('--developer_dir', required=False,
+ help='Path to Xcode.')
args, unknown_args = parser.parse_known_args()
+ if (args.developer_dir):
sdefresne 2016/10/07 13:25:16 style: parenthesis should have been omitted there
+ os.environ['DEVELOPER_DIR'] = args.developer_dir
+
ibtool_args = [
'xcrun', 'ibtool',
'--errors', '--warnings', '--notices',

Powered by Google App Engine
This is Rietveld 408576698