Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: build/config/mac/base_rules.gni

Issue 2388063003: Add a variable use_system_xcode to GN. (Closed)
Patch Set: Comments from dpranke. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/mac/compile_xib.py » ('j') | build/config/mac/compile_xib.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/mac/base_rules.gni
diff --git a/build/config/mac/base_rules.gni b/build/config/mac/base_rules.gni
index 4e34cb53c8021772a414dcd32123671fb422b18f..266878ef7d0f829ea29977c4f1197f916c05d1dc 100644
--- a/build/config/mac/base_rules.gni
+++ b/build/config/mac/base_rules.gni
@@ -155,12 +155,18 @@ template("compile_xibs") {
outputs = [
"$target_gen_dir/$target_name/{{source_name_part}}.nib",
]
- args =
- [
- "--input",
- "{{source}}",
- "--output",
- rebase_path("$target_gen_dir/$target_name/{{source_name_part}}.nib"),
- ] + ibtool_flags
+ args = [
+ "--input",
+ "{{source}}",
+ "--output",
+ rebase_path("$target_gen_dir/$target_name/{{source_name_part}}.nib"),
+ ]
+ if (!use_system_xcode) {
+ args += [
+ "--developer_dir",
+ hermetic_xcode_path,
+ ]
+ }
+ args += ibtool_flags
}
}
« no previous file with comments | « no previous file | build/config/mac/compile_xib.py » ('j') | build/config/mac/compile_xib.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698