Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 2388003002: Prune createVisibleSelectionDeprecated from GranularityStrategy (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune createVisibleSelectionDeprecated from GranularityStrategy BUG=651373 Committed: https://crrev.com/930e0247b7f381345cfe71a0f5c4e19c7c0486b2 Cr-Commit-Position: refs/heads/master@{#422379}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M third_party/WebKit/Source/core/editing/GranularityStrategy.cpp View 2 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-03 06:10:23 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-03 06:28:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2388003002/1
4 years, 2 months ago (2016-10-03 06:43:57 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 06:47:59 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 06:50:26 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/930e0247b7f381345cfe71a0f5c4e19c7c0486b2
Cr-Commit-Position: refs/heads/master@{#422379}

Powered by Google App Engine
This is Rietveld 408576698