Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(465)

Unified Diff: third_party/WebKit/Source/core/editing/GranularityStrategy.cpp

Issue 2388003002: Prune createVisibleSelectionDeprecated from GranularityStrategy (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/GranularityStrategy.cpp
diff --git a/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp b/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp
index c24cd43d01c7cb35756090112604689b4de817f3..b5b5fcd9747eb41bddd86a776cd36e8a18f6524f 100644
--- a/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp
+++ b/third_party/WebKit/Source/core/editing/GranularityStrategy.cpp
@@ -71,8 +71,7 @@ VisibleSelection CharacterGranularityStrategy::updateExtent(
if (selection.visibleBase().deepEquivalent() ==
extentPosition.deepEquivalent())
return selection;
- return createVisibleSelectionDeprecated(selection.visibleBase(),
- extentPosition);
+ return createVisibleSelection(selection.visibleBase(), extentPosition);
}
DirectionGranularityStrategy::DirectionGranularityStrategy()
@@ -147,9 +146,10 @@ VisibleSelection DirectionGranularityStrategy::updateExtent(
// strategy if we detect that the text's baseline coordinate changed
// without a line change.
if (verticalChange &&
- inSameLine(newOffsetExtentPosition, oldOffsetExtentPosition))
- return createVisibleSelectionDeprecated(selection.visibleBase(),
- newOffsetExtentPosition);
+ inSameLine(newOffsetExtentPosition, oldOffsetExtentPosition)) {
+ return createVisibleSelection(selection.visibleBase(),
+ newOffsetExtentPosition);
+ }
int oldExtentBaseOrder = selection.isBaseFirst() ? 1 : -1;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698