Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(61)

Issue 2387963003: Temporarily remove a DCHECK from createVisibleSelection (Closed)

Created:
4 years, 2 months ago by Xiaocheng
Modified:
4 years, 2 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily remove a DCHECK from createVisibleSelection This patch removes DCHECK(base.isNotNull() || extent.isNull()) from createVisibleSelection because it doesn't hold for all callers. It will be added back after we have ensured that. BUG=651373 Committed: https://crrev.com/7731ccff648c8feb3ede2b8668a25dc0d3a7acfc Cr-Commit-Position: refs/heads/master@{#422371}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 4 chunks +8 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Xiaocheng
PTAL.
4 years, 2 months ago (2016-10-03 03:59:39 UTC) #4
yosin_UTC9
lgtm
4 years, 2 months ago (2016-10-03 04:04:08 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387963003/1
4 years, 2 months ago (2016-10-03 04:18:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-03 04:23:31 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-03 04:27:13 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7731ccff648c8feb3ede2b8668a25dc0d3a7acfc
Cr-Commit-Position: refs/heads/master@{#422371}

Powered by Google App Engine
This is Rietveld 408576698