Temporarily remove a DCHECK from createVisibleSelection

third_party/WebKit/Source/core/editing/VisibleSelection.cpp

 /*
  * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 206 matching lines @@
   DCHECK(!needsLayoutTreeUpdate(pos));
   return VisibleSelection::create(pos, pos, affinity, isDirectional);
 }
 
 VisibleSelection createVisibleSelection(const Position& base,
                                         const Position& extent,
                                         TextAffinity affinity,
                                         bool isDirectional) {
   DCHECK(!needsLayoutTreeUpdate(base));
   DCHECK(!needsLayoutTreeUpdate(extent));
-  DCHECK(base.isNotNull() || extent.isNull());
+  // TODO(xiaochengh): We should check |base.isNotNull() || extent.isNull()|
+  // after all call sites have ensured that.
   return VisibleSelection::create(base, extent, affinity, isDirectional);
 }
 
 VisibleSelection createVisibleSelection(const PositionWithAffinity& pos,
                                         bool isDirectional) {
   DCHECK(!needsLayoutTreeUpdate(pos.position()));
   return VisibleSelection::create(pos.position(), pos.position(),
                                   pos.affinity(), isDirectional);
 }
 
 VisibleSelection createVisibleSelection(const VisiblePosition& pos,
                                         bool isDirectional) {
   DCHECK(pos.isValid());
   return VisibleSelection::create(pos.deepEquivalent(), pos.deepEquivalent(),
                                   pos.affinity(), isDirectional);
 }
 
 VisibleSelection createVisibleSelection(const VisiblePosition& base,
                                         const VisiblePosition& extent,
                                         bool isDirectional) {
   DCHECK(base.isValid());
   DCHECK(extent.isValid());
-  DCHECK(base.isNotNull() || extent.isNull());
+  // TODO(xiaochengh): We should check |base.isNotNull() || extent.isNull()|
+  // after all call sites have ensured that.
   return VisibleSelection::create(base.deepEquivalent(),
                                   extent.deepEquivalent(), base.affinity(),
                                   isDirectional);
 }
 
 VisibleSelection createVisibleSelection(const EphemeralRange& range,
                                         TextAffinity affinity,
                                         bool isDirectional) {
   DCHECK(!needsLayoutTreeUpdate(range.startPosition()));
   DCHECK(!needsLayoutTreeUpdate(range.endPosition()));
   return VisibleSelection::create(range.startPosition(), range.endPosition(),
                                   affinity, isDirectional);
 }
 
 VisibleSelectionInFlatTree createVisibleSelection(const PositionInFlatTree& pos,
                                                   TextAffinity affinity,
                                                   bool isDirectional) {
   DCHECK(!needsLayoutTreeUpdate(pos));
   return VisibleSelectionInFlatTree::create(pos, pos, affinity, isDirectional);
 }
 
 VisibleSelectionInFlatTree createVisibleSelection(
     const PositionInFlatTree& base,
     const PositionInFlatTree& extent,
     TextAffinity affinity,
     bool isDirectional) {
   DCHECK(!needsLayoutTreeUpdate(base));
   DCHECK(!needsLayoutTreeUpdate(extent));
-  DCHECK(base.isNotNull() || extent.isNull());
+  // TODO(xiaochengh): We should check |base.isNotNull() || extent.isNull()|
+  // after all call sites have ensured that.
   return VisibleSelectionInFlatTree::create(base, extent, affinity,
                                             isDirectional);
 }
 
 VisibleSelectionInFlatTree createVisibleSelection(
     const PositionInFlatTreeWithAffinity& pos,
     bool isDirectional) {
   DCHECK(!needsLayoutTreeUpdate(pos.position()));
   return VisibleSelectionInFlatTree::create(pos.position(), pos.position(),
                                             pos.affinity(), isDirectional);
 }
 
 VisibleSelectionInFlatTree createVisibleSelection(
     const VisiblePositionInFlatTree& pos,
     bool isDirectional) {
   DCHECK(pos.isValid());
   return VisibleSelectionInFlatTree::create(pos.deepEquivalent(),
                                             pos.deepEquivalent(),
                                             pos.affinity(), isDirectional);
 }
 
 VisibleSelectionInFlatTree createVisibleSelection(
     const VisiblePositionInFlatTree& base,
     const VisiblePositionInFlatTree& extent,
     bool isDirectional) {
   DCHECK(base.isValid());
   DCHECK(extent.isValid());
-  DCHECK(base.isNotNull() || extent.isNull());
+  // TODO(xiaochengh): We should check |base.isNotNull() || extent.isNull()|
+  // after all call sites have ensured that.
   return VisibleSelectionInFlatTree::create(base.deepEquivalent(),
                                             extent.deepEquivalent(),
                                             base.affinity(), isDirectional);
 }
 
 VisibleSelectionInFlatTree createVisibleSelection(
     const EphemeralRangeInFlatTree& range,
     TextAffinity affinity,
     bool isDirectional) {
   DCHECK(!needsLayoutTreeUpdate(range.startPosition()));
@@ skipping 800 matching lines @@
 
 void showTree(const blink::VisibleSelectionInFlatTree& sel) {
   sel.showTreeForThis();
 }
 
 void showTree(const blink::VisibleSelectionInFlatTree* sel) {
   if (sel)
     sel->showTreeForThis();
 }
 #endif