|
|
Created:
4 years, 2 months ago by Nico Modified:
4 years, 2 months ago Reviewers:
Reid Kleckner CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, sof Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptionclang/win: Remove FIXME now that we don't need /fallback any more.
Morally reverts https://codereview.chromium.org/294653002.
BUG=345874
Committed: https://crrev.com/9854feae23c0165dc064dc5859c3cae99dd5255f
Cr-Commit-Position: refs/heads/master@{#422841}
Patch Set 1 #Patch Set 2 : rebase #Patch Set 3 : rebase once more #Messages
Total messages: 21 (16 generated)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
thakis@chromium.org changed reviewers: + rnk@chromium.org
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by thakis@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by thakis@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from rnk@chromium.org Link to the patchset: https://codereview.chromium.org/2387903002/#ps40001 (title: "rebase once more")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== clang/win: Remove FIXME now that we don't need /fallback any more. Morally reverts https://codereview.chromium.org/294653002. BUG=345874 ========== to ========== clang/win: Remove FIXME now that we don't need /fallback any more. Morally reverts https://codereview.chromium.org/294653002. BUG=345874 Committed: https://crrev.com/9854feae23c0165dc064dc5859c3cae99dd5255f Cr-Commit-Position: refs/heads/master@{#422841} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/9854feae23c0165dc064dc5859c3cae99dd5255f Cr-Commit-Position: refs/heads/master@{#422841} |