Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 2387903002: clang/win: Remove FIXME now that we don't need /fallback any more. (Closed)

Created:
4 years, 2 months ago by Nico
Modified:
4 years, 2 months ago
Reviewers:
Reid Kleckner
CC:
chromium-reviews, blink-reviews, blink-reviews-wtf_chromium.org, Mikhail, sof
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Remove FIXME now that we don't need /fallback any more. Morally reverts https://codereview.chromium.org/294653002. BUG=345874 Committed: https://crrev.com/9854feae23c0165dc064dc5859c3cae99dd5255f Cr-Commit-Position: refs/heads/master@{#422841}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase once more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -14 lines) Patch
M third_party/WebKit/Source/wtf/AddressSanitizer.h View 1 2 2 chunks +3 lines, -14 lines 0 comments Download

Messages

Total messages: 21 (16 generated)
Nico
4 years, 2 months ago (2016-10-02 00:59:58 UTC) #4
Reid Kleckner
lgtm
4 years, 2 months ago (2016-10-04 00:18:01 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387903002/40001
4 years, 2 months ago (2016-10-04 14:27:59 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 2 months ago (2016-10-04 17:23:59 UTC) #19
commit-bot: I haz the power
4 years, 2 months ago (2016-10-04 17:29:03 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/9854feae23c0165dc064dc5859c3cae99dd5255f
Cr-Commit-Position: refs/heads/master@{#422841}

Powered by Google App Engine
This is Rietveld 408576698