Issue 294653002: Define the NO_SANITIZE_ADDRESS macro in a 'clang-cl /fallback' friendly way

Issue 294653002: Define the NO_SANITIZE_ADDRESS macro in a 'clang-cl /fallback' friendly way (Closed)

Created:
6 years, 7 months ago by Timur Iskhodzhanov

Modified:
6 years, 7 months ago

Reviewers:
Alexander Potapenko, Mads Ager (chromium)

CC:
blink-reviews, haraken, kouhei+heap_chromium.org, Mads Ager (chromium)

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Define the NO_SANITIZE_ADDRESS macro in a 'clang-cl /fallback' friendly way BUG=chromium:345874 TEST=build chrome with "set GYP_DEFINES=clang=1 asan=1 component=static_library disable_nacl=1" Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174286

Patch Set 1 #

Patch Set 2 : Fix a duplicate macro definition #

Total comments: 2

Patch Set 3 : Address the comment #

Created: 6 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	Source/platform/heap/AddressSanitizer.h	View	1 2	1 chunk	+9 lines, -1 line	0 comments	Download

Messages

Total messages: 8 (0 generated)

Expand Messages | Collapse Messages

Timur Iskhodzhanov

Hi Mads, Can you please take a look at this small change? -- Tim

6 years, 7 months ago (2014-05-19 11:40:50 UTC) #2

Mads Ager (chromium)

LGTM https://codereview.chromium.org/294653002/diff/20001/Source/platform/heap/AddressSanitizer.h File Source/platform/heap/AddressSanitizer.h (right): https://codereview.chromium.org/294653002/diff/20001/Source/platform/heap/AddressSanitizer.h#newcode48 Source/platform/heap/AddressSanitizer.h:48: #if defined(ADDRESS_SANITIZER) && (!defined(_WIN32) || defined(__clang__)) Please use ...

6 years, 7 months ago (2014-05-19 11:41:56 UTC) #3

Timur Iskhodzhanov

Thanks! https://codereview.chromium.org/294653002/diff/20001/Source/platform/heap/AddressSanitizer.h File Source/platform/heap/AddressSanitizer.h (right): https://codereview.chromium.org/294653002/diff/20001/Source/platform/heap/AddressSanitizer.h#newcode48 Source/platform/heap/AddressSanitizer.h:48: #if defined(ADDRESS_SANITIZER) && (!defined(_WIN32) || defined(__clang__)) On 2014/05/19 ...

6 years, 7 months ago (2014-05-19 11:44:34 UTC) #4

Timur Iskhodzhanov

The CQ bit was checked by timurrrr@chromium.org

6 years, 7 months ago (2014-05-19 11:44:39 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/timurrrr@chromium.org/294653002/40001

6 years, 7 months ago (2014-05-19 11:45:00 UTC) #6

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...

6 years, 7 months ago (2014-05-19 13:01:47 UTC) #7

Message was sent while issue was closed.

Change committed as 174286

Expand Messages | Collapse Messages