Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/public/platform/WebLayer.h

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/platform/scroll/ScrollableArea.h ('K') | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | ui/gfx/geometry/scroll_offset.h » ('j') | ui/gfx/geometry/scroll_offset.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/WebLayer.h
diff --git a/third_party/WebKit/public/platform/WebLayer.h b/third_party/WebKit/public/platform/WebLayer.h
index 47a033417518bbb4961902213d4c85923d0d5bc1..9d632dbda546f8bca2daf557bfd52b6ce5535e3c 100644
--- a/third_party/WebKit/public/platform/WebLayer.h
+++ b/third_party/WebKit/public/platform/WebLayer.h
@@ -159,8 +159,8 @@ class WebLayer {
virtual void setClipParent(WebLayer*) = 0;
// Scrolling
- virtual void setScrollPositionDouble(WebDoublePoint) = 0;
- virtual WebDoublePoint scrollPositionDouble() const = 0;
+ virtual void setScrollOffset(WebFloatSize) = 0;
skobes 2016/10/05 21:19:28 Shouldn't these be "position"? WebLayer should us
szager1 2016/10/06 00:11:57 Good point, fixed.
+ virtual WebFloatSize scrollOffset() const = 0;
// To set a WebLayer as scrollable we must specify the corresponding clip
// layer.
« third_party/WebKit/Source/platform/scroll/ScrollableArea.h ('K') | « third_party/WebKit/Source/web/tests/WebViewTest.cpp ('k') | ui/gfx/geometry/scroll_offset.h » ('j') | ui/gfx/geometry/scroll_offset.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698