Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Side by Side Diff: third_party/WebKit/public/platform/WebLayer.h

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: rebase Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 // delta and offset even though it will not be a descendant of the scroll 152 // delta and offset even though it will not be a descendant of the scroll
153 // in the layer hierarchy. 153 // in the layer hierarchy.
154 virtual void setScrollParent(WebLayer*) = 0; 154 virtual void setScrollParent(WebLayer*) = 0;
155 155
156 // A layer will not respect any clips established by layers between it and 156 // A layer will not respect any clips established by layers between it and
157 // its nearest clipping ancestor. Note, the clip parent must be an ancestor. 157 // its nearest clipping ancestor. Note, the clip parent must be an ancestor.
158 // This is not a requirement of the scroll parent. 158 // This is not a requirement of the scroll parent.
159 virtual void setClipParent(WebLayer*) = 0; 159 virtual void setClipParent(WebLayer*) = 0;
160 160
161 // Scrolling 161 // Scrolling
162 virtual void setScrollPositionDouble(WebDoublePoint) = 0; 162 virtual void setScrollOffset(WebFloatSize) = 0;
skobes 2016/10/05 21:19:28 Shouldn't these be "position"? WebLayer should us
szager1 2016/10/06 00:11:57 Good point, fixed.
163 virtual WebDoublePoint scrollPositionDouble() const = 0; 163 virtual WebFloatSize scrollOffset() const = 0;
164 164
165 // To set a WebLayer as scrollable we must specify the corresponding clip 165 // To set a WebLayer as scrollable we must specify the corresponding clip
166 // layer. 166 // layer.
167 virtual void setScrollClipLayer(WebLayer*) = 0; 167 virtual void setScrollClipLayer(WebLayer*) = 0;
168 virtual bool scrollable() const = 0; 168 virtual bool scrollable() const = 0;
169 virtual void setUserScrollable(bool horizontal, bool vertical) = 0; 169 virtual void setUserScrollable(bool horizontal, bool vertical) = 0;
170 virtual bool userScrollableHorizontal() const = 0; 170 virtual bool userScrollableHorizontal() const = 0;
171 virtual bool userScrollableVertical() const = 0; 171 virtual bool userScrollableVertical() const = 0;
172 172
173 // Indicates that this layer will always scroll on the main thread for the 173 // Indicates that this layer will always scroll on the main thread for the
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 217
218 virtual void setCompositorMutableProperties(uint32_t) = 0; 218 virtual void setCompositorMutableProperties(uint32_t) = 0;
219 virtual uint32_t compositorMutableProperties() const = 0; 219 virtual uint32_t compositorMutableProperties() const = 0;
220 220
221 virtual void setHasWillChangeTransformHint(bool) = 0; 221 virtual void setHasWillChangeTransformHint(bool) = 0;
222 }; 222 };
223 223
224 } // namespace blink 224 } // namespace blink
225 225
226 #endif // WebLayer_h 226 #endif // WebLayer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698