third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Fix README.md Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

index 68cc8c28edfae3c546efd1acae547db13cda0950..f3d36dc1736034febf28c85e2cc2e593ad5d4d5d 100644

--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

@@ -210,8 +210,8 @@ TEST_F(ScrollingCoordinatorTest, fastFractionalScrollingDiv) {

WebLayer* webScrollLayer =

compositedLayerMapping->scrollingContentsLayer()->platformLayer();

ASSERT_TRUE(webScrollLayer);

- ASSERT_NEAR(1.2, webScrollLayer->scrollPositionDouble().x, 0.01);

- ASSERT_NEAR(1.2, webScrollLayer->scrollPositionDouble().y, 0.01);

+ ASSERT_NEAR(1.2f, webScrollLayer->scrollPositionDouble().x, 0.01f);

+ ASSERT_NEAR(1.2f, webScrollLayer->scrollPositionDouble().y, 0.01f);

RuntimeEnabledFeatures::setFractionalScrollOffsetsEnabled(

origFractionalOffsetsEnabled);