Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: third_party/WebKit/Source/web/tests/RootScrollerTest.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp b/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
index c4f611c6eb6c4fd2c4aefacd16bd53d8794362b1..98120c244543475ae2bc5ecb086d0b0c0853cf0a 100644
--- a/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
+++ b/third_party/WebKit/Source/web/tests/RootScrollerTest.cpp
@@ -208,7 +208,7 @@ TEST_F(RootScrollerTest, TestSetRootScroller) {
webViewImpl()->handleInputEvent(
generateTouchGestureEvent(WebInputEvent::GestureScrollUpdate, 0, -100));
EXPECT_FLOAT_EQ(100, container->scrollTop());
- EXPECT_FLOAT_EQ(0, mainFrameView()->scrollPositionDouble().y());
+ EXPECT_FLOAT_EQ(0, mainFrameView()->scrollOffset().height());
}
{
@@ -219,7 +219,7 @@ TEST_F(RootScrollerTest, TestSetRootScroller) {
webViewImpl()->handleInputEvent(
generateTouchGestureEvent(WebInputEvent::GestureScrollUpdate, 0, -550));
EXPECT_FLOAT_EQ(maximumScroll, container->scrollTop());
- EXPECT_FLOAT_EQ(0, mainFrameView()->scrollPositionDouble().y());
+ EXPECT_FLOAT_EQ(0, mainFrameView()->scrollOffset().height());
Mock::VerifyAndClearExpectations(&client);
}
@@ -230,7 +230,7 @@ TEST_F(RootScrollerTest, TestSetRootScroller) {
webViewImpl()->handleInputEvent(
generateTouchGestureEvent(WebInputEvent::GestureScrollUpdate, 0, -20));
EXPECT_FLOAT_EQ(maximumScroll, container->scrollTop());
- EXPECT_FLOAT_EQ(0, mainFrameView()->scrollPositionDouble().y());
+ EXPECT_FLOAT_EQ(0, mainFrameView()->scrollOffset().height());
Mock::VerifyAndClearExpectations(&client);
}
@@ -248,7 +248,7 @@ TEST_F(RootScrollerTest, TestSetRootScroller) {
webViewImpl()->handleInputEvent(
generateTouchGestureEvent(WebInputEvent::GestureScrollUpdate, 0, -30));
EXPECT_FLOAT_EQ(maximumScroll, container->scrollTop());
- EXPECT_FLOAT_EQ(0, mainFrameView()->scrollPositionDouble().y());
+ EXPECT_FLOAT_EQ(0, mainFrameView()->scrollOffset().height());
Mock::VerifyAndClearExpectations(&client);
webViewImpl()->handleInputEvent(

Powered by Google App Engine
This is Rietveld 408576698