Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Unified Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/page/Page.cpp
diff --git a/third_party/WebKit/Source/core/page/Page.cpp b/third_party/WebKit/Source/core/page/Page.cpp
index ab8a3283dd44f8ffe867f9e323ce07c38f29996d..d86ece1103a3f24dc760549f799999c57c1e5d3c 100644
--- a/third_party/WebKit/Source/core/page/Page.cpp
+++ b/third_party/WebKit/Source/core/page/Page.cpp
@@ -460,9 +460,10 @@ void Page::didCommitLoad(LocalFrame* frame) {
// Need to reset visual viewport position here since before commit load we
// would update the previous history item, Page::didCommitLoad is called
- // after a new history item is created in FrameLoader. See crbug.com/642279
- frameHost().visualViewport().setScrollPosition(DoublePoint(),
- ProgrammaticScroll);
+ // after a new history item is created in FrameLoader.
+ // See crbug.com/642279
+ frameHost().visualViewport().setScrollOffset(ScrollOffset(),
+ ProgrammaticScroll);
m_hostsUsingFeatures.updateMeasurementsAndClear();
UserGestureIndicator::clearProcessedUserGestureSinceLoad();
}
« no previous file with comments | « third_party/WebKit/Source/core/loader/HistoryItem.cpp ('k') | third_party/WebKit/Source/core/page/SpatialNavigation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698