Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Side by Side Diff: third_party/WebKit/Source/core/page/Page.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Fix README.md Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All 2 * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All
3 * Rights Reserved. 3 * Rights Reserved.
4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved. 4 * Copyright (C) 2008 Torch Mobile Inc. All rights reserved.
5 * (http://www.torchmobile.com/) 5 * (http://www.torchmobile.com/)
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 442 matching lines...) Expand 10 before | Expand all | Expand 10 after
453 if (m_mainFrame == frame) { 453 if (m_mainFrame == frame) {
454 // TODO(rbyers): Most of this doesn't appear to take into account that each 454 // TODO(rbyers): Most of this doesn't appear to take into account that each
455 // SVGImage gets it's own Page instance. 455 // SVGImage gets it's own Page instance.
456 frameHost().consoleMessageStorage().clear(); 456 frameHost().consoleMessageStorage().clear();
457 useCounter().didCommitLoad(); 457 useCounter().didCommitLoad();
458 deprecation().clearSuppression(); 458 deprecation().clearSuppression();
459 frameHost().visualViewport().sendUMAMetrics(); 459 frameHost().visualViewport().sendUMAMetrics();
460 460
461 // Need to reset visual viewport position here since before commit load we 461 // Need to reset visual viewport position here since before commit load we
462 // would update the previous history item, Page::didCommitLoad is called 462 // would update the previous history item, Page::didCommitLoad is called
463 // after a new history item is created in FrameLoader. See crbug.com/642279 463 // after a new history item is created in FrameLoader.
464 frameHost().visualViewport().setScrollPosition(DoublePoint(), 464 // See crbug.com/642279
465 ProgrammaticScroll); 465 frameHost().visualViewport().setScrollOffset(ScrollOffset(),
466 ProgrammaticScroll);
466 m_hostsUsingFeatures.updateMeasurementsAndClear(); 467 m_hostsUsingFeatures.updateMeasurementsAndClear();
467 UserGestureIndicator::clearProcessedUserGestureSinceLoad(); 468 UserGestureIndicator::clearProcessedUserGestureSinceLoad();
468 } 469 }
469 } 470 }
470 471
471 void Page::acceptLanguagesChanged() { 472 void Page::acceptLanguagesChanged() {
472 HeapVector<Member<LocalFrame>> frames; 473 HeapVector<Member<LocalFrame>> frames;
473 474
474 // Even though we don't fire an event from here, the LocalDOMWindow's will 475 // Even though we don't fire an event from here, the LocalDOMWindow's will
475 // fire an event so we keep the frames alive until we are done. 476 // fire an event so we keep the frames alive until we are done.
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
538 : chromeClient(nullptr), 539 : chromeClient(nullptr),
539 contextMenuClient(nullptr), 540 contextMenuClient(nullptr),
540 editorClient(nullptr), 541 editorClient(nullptr),
541 spellCheckerClient(nullptr) {} 542 spellCheckerClient(nullptr) {}
542 543
543 Page::PageClients::~PageClients() {} 544 Page::PageClients::~PageClients() {}
544 545
545 template class CORE_TEMPLATE_EXPORT Supplement<Page>; 546 template class CORE_TEMPLATE_EXPORT Supplement<Page>;
546 547
547 } // namespace blink 548 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/loader/HistoryItem.cpp ('k') | third_party/WebKit/Source/core/page/SpatialNavigation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698