third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.h ('K') | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMappingTest.cpp ('k') | third_party/WebKit/Source/core/loader/FrameLoader.cpp » ('j') | third_party/WebKit/Source/core/loader/HistoryItem.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

index 20791f1391c8371485b0420ae0f89d4cdd0dfbfa..588b7bcc8af6dc0052f98d5c11fe04dace7062d0 100644

--- a/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/PaintLayerCompositor.cpp

@@ -639,7 +639,7 @@ enum AcceleratedFixedRootBackgroundHistogramBuckets {

void PaintLayerCompositor::frameViewDidScroll() {

FrameView* frameView = m_layoutView.frameView();

- IntPoint scrollPosition = frameView->scrollPosition();

+ IntSize scrollOffset = frameView->scrollOffsetInt();

if (!m_scrollLayer)

return;

@@ -657,7 +657,7 @@ void PaintLayerCompositor::frameViewDidScroll() {

if (scrollingCoordinatorHandlesOffset)

m_scrollLayer->setPosition(frameView->scrollOrigin());

else

- m_scrollLayer->setPosition(-scrollPosition);

+ m_scrollLayer->setPosition(IntPoint(-scrollOffset));

DEFINE_STATIC_LOCAL(EnumerationHistogram, acceleratedBackgroundHistogram,

("Renderer.AcceleratedFixedRootBackground",