Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBox.h

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBox.h
diff --git a/third_party/WebKit/Source/core/layout/LayoutBox.h b/third_party/WebKit/Source/core/layout/LayoutBox.h
index cdde731ad1fc0b844582d2feea77321460922761..14a63f9ff7bdde5ae944169bd46e8f345dcc3e08 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBox.h
+++ b/third_party/WebKit/Source/core/layout/LayoutBox.h
@@ -547,9 +547,9 @@ class CORE_EXPORT LayoutBox : public LayoutBoxModelObject {
virtual void setScrollLeft(LayoutUnit);
virtual void setScrollTop(LayoutUnit);
- void scrollToOffset(const DoubleSize&,
- ScrollBehavior = ScrollBehaviorInstant);
- void scrollByRecursively(const DoubleSize& delta);
+ void scrollToPosition(const FloatPoint&,
bokan 2016/10/02 19:47:51 Why FloatPoint instead of ScrollOffset?
szager1 2016/10/05 07:43:36 The convention I'm using is: 'position' is a poin
bokan 2016/10/06 22:32:17 Acknowledged.
+ ScrollBehavior = ScrollBehaviorInstant);
+ void scrollByRecursively(const ScrollOffset& delta);
// If makeVisibleInVisualViewport is set, the visual viewport will be scrolled
// if required to make the rect visible.
void scrollRectToVisible(const LayoutRect&,

Powered by Google App Engine
This is Rietveld 408576698