third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp - Issue 2387883002: Use float for scroll offset.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

Issue 2387883002: Use float for scroll offset. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/LayoutBox.h ('K') | « third_party/WebKit/Source/core/layout/LayoutBoxModelObjectTest.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp » ('j') | third_party/WebKit/Source/core/loader/HistoryItem.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

index 94b545003a8837387098f65a4587e5997ceb294f..017e3869d901851659783ca5d9faba85c3b79eb2 100644

--- a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

@@ -452,7 +452,7 @@ void LayoutDeprecatedFlexibleBox::layoutHorizontalBox(bool relayoutChildren) {

gatherFlexChildrenInfo(iterator, relayoutChildren, highestFlexGroup,

lowestFlexGroup, haveFlex);

- PaintLayerScrollableArea::DelayScrollPositionClampScope delayClampScope;

+ PaintLayerScrollableArea::DelayScrollOffsetClampScope delayClampScope;

// We do 2 passes. The first pass is simply to lay everyone out at

// their preferred widths. The second pass handles flexing the children.

@@ -787,7 +787,7 @@ void LayoutDeprecatedFlexibleBox::layoutVerticalBox(bool relayoutChildren) {

if (haveLineClamp)

applyLineClamp(iterator, relayoutChildren);

- PaintLayerScrollableArea::DelayScrollPositionClampScope delayClampScope;

+ PaintLayerScrollableArea::DelayScrollOffsetClampScope delayClampScope;

// We do 2 passes. The first pass is simply to lay everyone out at

// their preferred widths. The second pass handles flexing the children.