Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
index cfeedd4c6bbd355bf8b39c708de3956c23141360..413f89baff71570d483a6fafaa8485ecf6c23a62 100644
--- a/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp
@@ -3722,9 +3722,8 @@ bool LayoutBlockFlow::hitTestFloats(HitTestResult& result,
LayoutPoint adjustedLocation = accumulatedOffset;
if (isLayoutView()) {
- DoublePoint position =
- toLayoutView(this)->frameView()->scrollPositionDouble();
- adjustedLocation.move(position.x(), position.y());
+ ScrollOffset offset = toLayoutView(this)->frameView()->scrollOffset();
+ adjustedLocation.move(LayoutSize(offset));
}
const FloatingObjectSet& floatingObjectSet = m_floatingObjects->set();
@@ -4019,7 +4018,7 @@ void LayoutBlockFlow::positionDialog() {
FrameView* frameView = document().view();
LayoutUnit top = LayoutUnit((style()->position() == FixedPosition)
? 0
- : frameView->scrollOffset().height());
+ : frameView->scrollOffsetInt().height());
int visibleHeight = frameView->visibleContentRect(IncludeScrollbars).height();
if (size().height() < visibleHeight)
top += (visibleHeight - size().height()) / 2;

Powered by Google App Engine
This is Rietveld 408576698