Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/input/PointerEventManager.cpp

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« third_party/WebKit/Source/core/frame/VisualViewport.h ('K') | « third_party/WebKit/Source/core/input/EventHandlerTest.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/input/PointerEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/PointerEventManager.cpp b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
index 9c1c959f29b6ab4c7e62e0a7f90508fdc5e12128..c4bfc008ca55aea2aa963665f76879f27de72d0e 100644
--- a/third_party/WebKit/Source/core/input/PointerEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/PointerEventManager.cpp
@@ -345,8 +345,7 @@ void PointerEventManager::dispatchTouchPointerEvents(
FloatPoint pagePoint = touchInfo.targetFrame->view()->rootFrameToContents(
touchInfo.point.pos());
float scaleFactor = 1.0f / touchInfo.targetFrame->pageZoomFactor();
- FloatPoint scrollPosition =
- touchInfo.targetFrame->view()->scrollPosition();
+ FloatPoint scrollPosition(touchInfo.targetFrame->view()->scrollOffset());
FloatPoint framePoint = pagePoint.scaledBy(scaleFactor);
framePoint.moveBy(scrollPosition.scaledBy(-scaleFactor));
PointerEvent* pointerEvent = m_pointerEventFactory.create(
« third_party/WebKit/Source/core/frame/VisualViewport.h ('K') | « third_party/WebKit/Source/core/input/EventHandlerTest.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutBlock.cpp » ('j') | third_party/WebKit/Source/core/layout/LayoutBox.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698