Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Unified Diff: third_party/WebKit/Source/core/frame/DOMVisualViewport.h

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/frame/DOMVisualViewport.h
diff --git a/third_party/WebKit/Source/core/frame/DOMVisualViewport.h b/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
index 6f27bb9fb73f7e0d53b9a18534cf28a17060926c..b1923f867e569e5b14d1c4b3825bedde00fa9046 100644
--- a/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
+++ b/third_party/WebKit/Source/core/frame/DOMVisualViewport.h
@@ -57,10 +57,10 @@ class DOMVisualViewport final : public EventTargetWithInlineData {
const AtomicString& interfaceName() const override;
ExecutionContext* getExecutionContext() const override;
- double scrollLeft();
- double scrollTop();
- double pageX();
- double pageY();
+ float scrollLeft();
bokan 2016/10/02 19:47:50 Perhaps we should have a ScrollUnit typedef?
szager1 2016/10/05 07:43:36 I'll add the typedef, but I'm not going to try and
+ float scrollTop();
+ float pageX();
+ float pageY();
double clientWidth();
double clientHeight();
double scale();

Powered by Google App Engine
This is Rietveld 408576698