Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: third_party/WebKit/Source/core/frame/DOMVisualViewport.h

Issue 2387883002: Use float for scroll offset. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2016 Google Inc. All rights reserved. 2 * Copyright (C) 2016 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 } 50 }
51 51
52 ~DOMVisualViewport() override; 52 ~DOMVisualViewport() override;
53 53
54 DECLARE_VIRTUAL_TRACE(); 54 DECLARE_VIRTUAL_TRACE();
55 55
56 // EventTarget overrides: 56 // EventTarget overrides:
57 const AtomicString& interfaceName() const override; 57 const AtomicString& interfaceName() const override;
58 ExecutionContext* getExecutionContext() const override; 58 ExecutionContext* getExecutionContext() const override;
59 59
60 double scrollLeft(); 60 float scrollLeft();
bokan 2016/10/02 19:47:50 Perhaps we should have a ScrollUnit typedef?
szager1 2016/10/05 07:43:36 I'll add the typedef, but I'm not going to try and
61 double scrollTop(); 61 float scrollTop();
62 double pageX(); 62 float pageX();
63 double pageY(); 63 float pageY();
64 double clientWidth(); 64 double clientWidth();
65 double clientHeight(); 65 double clientHeight();
66 double scale(); 66 double scale();
67 67
68 private: 68 private:
69 explicit DOMVisualViewport(LocalDOMWindow*); 69 explicit DOMVisualViewport(LocalDOMWindow*);
70 70
71 Member<LocalDOMWindow> m_window; 71 Member<LocalDOMWindow> m_window;
72 }; 72 };
73 73
74 } // namespace blink 74 } // namespace blink
75 75
76 #endif // DOMVisualViewport_h 76 #endif // DOMVisualViewport_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698