Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 238773009: Set code on the SharedFunctionInfo before creating the function. (Closed)

Created:
6 years, 8 months ago by Toon Verwaest
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Set code on the SharedFunctionInfo before creating the function. BUG= R=ishell@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20873

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -63 lines) Patch
M src/bootstrapper.cc View 7 chunks +19 lines, -24 lines 0 comments Download
M src/factory.h View 2 chunks +6 lines, -4 lines 0 comments Download
M src/factory.cc View 3 chunks +9 lines, -18 lines 0 comments Download
M test/cctest/test-alloc.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-heap.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M test/cctest/test-mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-weakmaps.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M test/cctest/test-weaksets.cc View 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 8 months ago (2014-04-17 11:43:56 UTC) #1
Igor Sheludko
lgtm
6 years, 8 months ago (2014-04-17 13:25:10 UTC) #2
Toon Verwaest
6 years, 8 months ago (2014-04-22 08:30:19 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698