test/cctest/test-heap.cc - Issue 238773009: Set code on the SharedFunctionInfo before creating the function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap.cc

Issue 238773009: Set code on the SharedFunctionInfo before creating the function. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap.cc

diff --git a/test/cctest/test-heap.cc b/test/cctest/test-heap.cc

index 318166536e7087c75af15b871fb3c09ab002c2de..a973bb9c534e466bf8fac0b1795e4bd183df826b 100644

--- a/test/cctest/test-heap.cc

+++ b/test/cctest/test-heap.cc

@@ -267,8 +267,8 @@ TEST(GarbageCollection) {

{

HandleScope inner_scope(isolate);

// Allocate a function and keep it in global object's property.

- Handle<JSFunction> function =

- factory->NewFunction(name, factory->undefined_value());

+ Handle<JSFunction> function = factory->NewFunctionWithPrototype(

+ name, factory->undefined_value());

Handle<Map> initial_map =

factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);

function->set_initial_map(*initial_map);

@@ -625,8 +625,8 @@ TEST(FunctionAllocation) {

v8::HandleScope sc(CcTest::isolate());

Handle<String> name = factory->InternalizeUtf8String("theFunction");

- Handle<JSFunction> function =

- factory->NewFunction(name, factory->undefined_value());

+ Handle<JSFunction> function = factory->NewFunctionWithPrototype(

+ name, factory->undefined_value());

Handle<Map> initial_map =

factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);

function->set_initial_map(*initial_map);

@@ -724,8 +724,8 @@ TEST(JSObjectMaps) {

v8::HandleScope sc(CcTest::isolate());

Handle<String> name = factory->InternalizeUtf8String("theFunction");

- Handle<JSFunction> function =

- factory->NewFunction(name, factory->undefined_value());

+ Handle<JSFunction> function = factory->NewFunctionWithPrototype(

+ name, factory->undefined_value());

Handle<Map> initial_map =

factory->NewMap(JS_OBJECT_TYPE, JSObject::kHeaderSize);

function->set_initial_map(*initial_map);

« no previous file with comments | « test/cctest/test-alloc.cc ('k') | test/cctest/test-mark-compact.cc » ('j') | no next file with comments »