Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 2387613003: Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPKs (Closed)

Created:
4 years, 2 months ago by pkotwicz
Modified:
3 years, 12 months ago
Reviewers:
Xi Han, gone
CC:
chromium-reviews, dominickn+watch_chromium.org, pkotwicz+watch_chromium.org, zpeng+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPKs This CL: - Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo is ignored for WebAPK compatible pages. - Adds tests checking that WebApplicationInfo is ignored BUG=638468 Committed: https://crrev.com/f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e Cr-Commit-Position: refs/heads/master@{#440013}

Patch Set 1 #

Patch Set 2 : Merge branch 'master' into test_flaky #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -3 lines) Patch
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher.cc View 1 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc View 1 4 chunks +64 lines, -1 line 1 comment Download

Messages

Total messages: 21 (13 generated)
pkotwicz
Dan can you please take a look? This CL is no different from the original ...
4 years, 1 month ago (2016-11-07 20:42:05 UTC) #3
pkotwicz
Actually, never mind. The new test fails on the first run (but not the second). ...
4 years, 1 month ago (2016-11-07 20:43:39 UTC) #4
gone
Re-add me as a reviewer when you figure this out. I've got too many CLs ...
4 years, 1 month ago (2016-11-08 18:30:47 UTC) #5
pkotwicz
Dan can you please take a look? This CL is identical to https://codereview.chromium.org/2362813003 with the ...
4 years ago (2016-12-20 00:09:44 UTC) #9
gone
lgtm https://codereview.chromium.org/2387613003/diff/40001/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc File chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc (right): https://codereview.chromium.org/2387613003/diff/40001/chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc#newcode327 chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc:327: RegisterServiceWorker(GURL(kDefaultStartUrl)); Lines 327 and 333 are (more or ...
3 years, 12 months ago (2016-12-20 18:44:14 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2387613003/40001
3 years, 12 months ago (2016-12-21 04:06:26 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
3 years, 12 months ago (2016-12-21 04:18:22 UTC) #19
commit-bot: I haz the power
3 years, 12 months ago (2016-12-21 04:21:48 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e
Cr-Commit-Position: refs/heads/master@{#440013}

Powered by Google App Engine
This is Rietveld 408576698