Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPKs

Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo for WebAPKs

This CL:
- Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
  is ignored for WebAPK compatible pages.
- Adds tests checking that WebApplicationInfo is ignored

BUG=638468
Committed: https://crrev.com/f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e
Cr-Commit-Position: refs/heads/master@{#440013}

[pkotwicz, 2016-11-07 20:29:17]

Description was changed from

==========
ABCD
==========

to

==========
Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo
for WebAPKs

This CL:
- Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
  is ignored for WebAPK compatible pages.
- Adds tests checking that WebApplicationInfo is ignored

BUG=638468
==========

[pkotwicz, 2016-11-07 20:29:18]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-11-07 20:42:05]

Dan can you please take a look? This CL is no different from the original CL. It
looks like this CL no longer makes the android_n5x_swarming_rel bot flaky. (The
new tests have not failed on the last 10 try jobs)

[pkotwicz, 2016-11-07 20:43:39]

Actually, never mind. The new test fails on the first run (but not the second).
I will fix

[gone, 2016-11-08 18:30:47]

Re-add me as a reviewer when you figure this out.  I've got too many CLs in my
list to keep track of.

[gone, 2016-11-08 18:30:55]

dfalcantara@chromium.org changed reviewers:
- dfalcantara@chromium.org

[pkotwicz, 2016-12-19 05:29:47]

Patchset #2 (id:20001) has been deleted

[pkotwicz, 2016-12-20 00:09:43]

pkotwicz@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[pkotwicz, 2016-12-20 00:09:44]

Dan can you please take a look? This CL is identical to
https://codereview.chromium.org/2362813003 with the exception of
AddToHomescreenDataFetcherTest::TearDown()

It looks like the android_n5x_swarming_dbg failures are unrelated and the bot is
misbehaving.
Here's the error: Builder name "android_n5x_swarming_dbg"  not found under
masters

[gone, 2016-12-20 18:44:14]

lgtm

https://codereview.chromium.org/2387613003/diff/40001/chrome/browser/android/...
File chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc
(right):

https://codereview.chromium.org/2387613003/diff/40001/chrome/browser/android/...
chrome/browser/android/webapps/add_to_homescreen_data_fetcher_unittest.cc:327:
RegisterServiceWorker(GURL(kDefaultStartUrl));
Lines 327 and 333 are (more or less) repeated three different times, except that
you use 0 vs 10000 and with a different manifest.  Is it worth pulling it out?

[Xi Han, 2016-12-20 22:03:22]

The CQ bit was checked by hanxi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 22:04:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 22:35:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 22:35:43]

Dry run: This issue passed the CQ dry run.

[Xi Han, 2016-12-21 04:06:07]

The CQ bit was checked by hanxi@chromium.org

[commit-bot: I haz the power, 2016-12-21 04:06:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 04:17:54]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1482293167184630,
"parent_rev": "3661811692371b67a799ad0104cae9434a6452da", "commit_rev":
"11c8088392716ac900d8354cc03b062c59feed45"}

[commit-bot: I haz the power, 2016-12-21 04:18:19]

Description was changed from

==========
Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo
for WebAPKs

This CL:
- Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
  is ignored for WebAPK compatible pages.
- Adds tests checking that WebApplicationInfo is ignored

BUG=638468
==========

to

==========
Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo
for WebAPKs

This CL:
- Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
  is ignored for WebAPK compatible pages.
- Adds tests checking that WebApplicationInfo is ignored

BUG=638468

Review-Url: https://codereview.chromium.org/2387613003
==========

[commit-bot: I haz the power, 2016-12-21 04:18:22]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-12-21 04:21:47]

Description was changed from

==========
Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo
for WebAPKs

This CL:
- Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
  is ignored for WebAPK compatible pages.
- Adds tests checking that WebApplicationInfo is ignored

BUG=638468

Review-Url: https://codereview.chromium.org/2387613003
==========

to

==========
Reland: Make it clear that AddToHomescreenDataFetcher ignores WebApplicationInfo
for WebAPKs

This CL:
- Changes AddToHomescreenDataFetcher to make it clearer that WebApplicationInfo
  is ignored for WebAPK compatible pages.
- Adds tests checking that WebApplicationInfo is ignored

BUG=638468

Committed: https://crrev.com/f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e
Cr-Commit-Position: refs/heads/master@{#440013}
==========

[commit-bot: I haz the power, 2016-12-21 04:21:48]

Patchset 2 (id:??) landed as
https://crrev.com/f52ce748b8d8ad8d5fe9d8d29e48a74157e47f4e
Cr-Commit-Position: refs/heads/master@{#440013}