Source/bindings/v8/V8Callback.cpp - Issue 23876015: Pass isolate to v8::Local<>::New() factory function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Callback.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use isolateForFrame() Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8Callback.cpp

diff --git a/Source/bindings/v8/V8Callback.cpp b/Source/bindings/v8/V8Callback.cpp

index d103c34989111184e978bc67f4d011af22a58c8d..33ba790616501c4e57f787523a8ebf25074bb26a 100644

--- a/Source/bindings/v8/V8Callback.cpp

+++ b/Source/bindings/v8/V8Callback.cpp

@@ -48,7 +48,7 @@ bool invokeCallback(v8::Handle<v8::Object> callback, v8::Handle<v8::Object> this

v8::Local<v8::Function> callbackFunction;

if (callback->IsFunction()) {

- callbackFunction = v8::Local<v8::Function>::New(v8::Handle<v8::Function>::Cast(callback));

+ callbackFunction = v8::Local<v8::Function>::New(isolate, v8::Handle<v8::Function>::Cast(callback));

} else if (callback->IsObject()) {

v8::Local<v8::Value> handleEventFunction = callback->Get(v8::String::NewSymbol("handleEvent"));

if (handleEventFunction->IsFunction())