Source/bindings/v8/V8Binding.cpp - Issue 23876015: Pass isolate to v8::Local<>::New() factory function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/v8/V8Binding.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Use isolateForFrame() Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/v8/V8Binding.cpp

diff --git a/Source/bindings/v8/V8Binding.cpp b/Source/bindings/v8/V8Binding.cpp

index 275e0d8d7fa6769958c9290f02f12f0de283f3dc..13d8c1f74fb4be5ede60d77d128f479c93abe727 100644

--- a/Source/bindings/v8/V8Binding.cpp

+++ b/Source/bindings/v8/V8Binding.cpp

@@ -397,7 +397,7 @@ v8::Handle<v8::FunctionTemplate> createRawTemplate(v8::Isolate* isolate)

PassRefPtr<DOMStringList> toDOMStringList(v8::Handle<v8::Value> value, v8::Isolate* isolate)

{

- v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(value));

+ v8::Local<v8::Value> v8Value(v8::Local<v8::Value>::New(isolate, value));

if (V8DOMStringList::HasInstance(v8Value, isolate, worldType(isolate))) {

RefPtr<DOMStringList> ret = V8DOMStringList::toNative(v8::Handle<v8::Object>::Cast(v8Value));