Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Unified Diff: Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
diff --git a/Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp b/Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
index f2fee0d4dd58bdde6f150ad5cb545adc2308bb26..902110b9c5443e5f8c3ca11f4186dec11a706538 100644
--- a/Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
+++ b/Source/bindings/v8/V8WorkerGlobalScopeEventListener.cpp
@@ -114,10 +114,11 @@ v8::Local<v8::Object> V8WorkerGlobalScopeEventListener::getReceiverObject(Script
return listener;
EventTarget* target = event->currentTarget();
- v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), toV8Context(context, world())->GetIsolate());
+ v8::Isolate* isolate = toV8Context(context, world())->GetIsolate();
marja 2013/09/12 07:41:21 I think you should use getIsolateFromScriptExecuti
+ v8::Handle<v8::Value> value = toV8(target, v8::Handle<v8::Object>(), isolate);
if (value.IsEmpty())
return v8::Local<v8::Object>();
- return v8::Local<v8::Object>::New(v8::Handle<v8::Object>::Cast(value));
+ return v8::Local<v8::Object>::New(isolate, v8::Handle<v8::Object>::Cast(value));
}
} // namespace WebCore

Powered by Google App Engine
This is Rietveld 408576698