Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: Source/web/WebFrameImpl.cpp

Issue 23876015: Pass isolate to v8::Local<>::New() factory function (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebFrameImpl.cpp
diff --git a/Source/web/WebFrameImpl.cpp b/Source/web/WebFrameImpl.cpp
index 4164e8820bce07b124cb7fedbe4533dab24711d5..1e5a8151bb90f52b8a16086277b85f1f717740fe 100644
--- a/Source/web/WebFrameImpl.cpp
+++ b/Source/web/WebFrameImpl.cpp
@@ -857,7 +857,7 @@ void WebFrameImpl::executeScriptInIsolatedWorld(int worldID, const WebScriptSour
frame()->script()->executeScriptInIsolatedWorld(worldID, sources, extensionGroup, &scriptResults);
WebVector<v8::Local<v8::Value> > v8Results(scriptResults.size());
for (unsigned i = 0; i < scriptResults.size(); i++)
- v8Results[i] = v8::Local<v8::Value>::New(scriptResults[i].v8Value());
+ v8Results[i] = v8::Local<v8::Value>::New(frame()->script()->currentWorldContext()->GetIsolate(), scriptResults[i].v8Value());
marja 2013/09/12 07:41:21 Oops, we should also have getIsolateFromFrame, at
do-not-use 2013/09/12 12:07:32 isolateForFrame() does: frame->script()->isolate()
results->swap(v8Results);
} else
frame()->script()->executeScriptInIsolatedWorld(worldID, sources, extensionGroup, 0);

Powered by Google App Engine
This is Rietveld 408576698