Issue 238753003: Remove assertion from callers of TryCall.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 238753003: Remove assertion from callers of TryCall. (Closed)

Created:
6 years, 8 months ago by Yang

Modified:
6 years, 8 months ago

Reviewers:
Igor Sheludko

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Remove assertion from callers of TryCall. R=ishell@chromium.org BUG=363280 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20748

Patch Set 2 : fix #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+29 lines, -43 lines)			Patch
	M	src/debug.cc	View	1	11 chunks	+23 lines, -36 lines	0 comments	Download
	M	src/execution.cc	View		1 chunk	+6 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Igor Sheludko

lgtm after you fix this: https://codereview.chromium.org/238753003/diff/1/src/debug.cc File src/debug.cc (right): https://codereview.chromium.org/238753003/diff/1/src/debug.cc#newcode3294 src/debug.cc:3294: isolate_->factory()->undefined_value(); return

6 years, 8 months ago (2014-04-15 07:52:31 UTC) #2

Yang

https://codereview.chromium.org/238753003/diff/1/src/debug.cc File src/debug.cc (right): https://codereview.chromium.org/238753003/diff/1/src/debug.cc#newcode3294 src/debug.cc:3294: isolate_->factory()->undefined_value(); On 2014/04/15 07:52:31, Igor Sheludko wrote: > return ...

6 years, 8 months ago (2014-04-15 07:54:29 UTC) #3

Yang

6 years, 8 months ago (2014-04-15 07:56:06 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r20748 (presubmit successful).

Expand Messages | Collapse Messages

Issue 238753003: Remove assertion from callers of TryCall. (Closed)

Description

Patch Set 1 #

Patch Set 2 : fix #

Messages