Chromium Code Reviews

Issue 238753003: Remove assertion from callers of TryCall. (Closed)

Created:
6 years, 8 months ago by Yang
Modified:
6 years, 8 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Visibility:
Public.

Description

Remove assertion from callers of TryCall. R=ishell@chromium.org BUG=363280 LOG=N Committed: https://code.google.com/p/v8/source/detail?r=20748

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Unified diffs Side-by-side diffs Stats (+29 lines, -43 lines)
M src/debug.cc View 11 chunks +23 lines, -36 lines 0 comments
M src/execution.cc View 1 chunk +6 lines, -7 lines 0 comments

Messages

Total messages: 4 (0 generated)
Yang
6 years, 8 months ago (2014-04-15 07:46:44 UTC) #1
Igor Sheludko
lgtm after you fix this: https://codereview.chromium.org/238753003/diff/1/src/debug.cc File src/debug.cc (right): https://codereview.chromium.org/238753003/diff/1/src/debug.cc#newcode3294 src/debug.cc:3294: isolate_->factory()->undefined_value(); return
6 years, 8 months ago (2014-04-15 07:52:31 UTC) #2
Yang
https://codereview.chromium.org/238753003/diff/1/src/debug.cc File src/debug.cc (right): https://codereview.chromium.org/238753003/diff/1/src/debug.cc#newcode3294 src/debug.cc:3294: isolate_->factory()->undefined_value(); On 2014/04/15 07:52:31, Igor Sheludko wrote: > return ...
6 years, 8 months ago (2014-04-15 07:54:29 UTC) #3
Yang
6 years, 8 months ago (2014-04-15 07:56:06 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r20748 (presubmit successful).

Powered by Google App Engine