Add SyncSocket::ReceiveWithTimeout() and SyncSocket unit tests.

base/sync_socket_nacl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/sync_socket.h"
 
 #include <errno.h>
 #include <limits.h>
 #include <stdio.h>
 #include <sys/types.h>
@@ skipping 27 matching lines @@
 
 size_t SyncSocket::Send(const void* buffer, size_t length) {
   // Not implemented since it's not needed by any client code yet.
   return -1;
 }
 
 size_t SyncSocket::Receive(void* buffer, size_t length) {
   return read(handle_, buffer, length);
 }
 
+size_t SyncSocket::ReceiveWithTimeout(void* buffer, size_t length, TimeDelta) {
+  return -1;

[jar (doing other things), 2013/10/14 15:31:07]

Shouldn't this be return 0?

[DaleCurtis, 2013/10/14 19:25:13]

I just copied the pattern, but probably all of these should return 0 since
they're size_t and also call NOTIMPLEMENTED().  I've changed them all.

+}
+
 size_t SyncSocket::Peek() {
   return -1;
 }
 
 CancelableSyncSocket::CancelableSyncSocket() {
 }
 
 CancelableSyncSocket::CancelableSyncSocket(Handle handle)
     : SyncSocket(handle) {
 }
 
 size_t CancelableSyncSocket::Send(const void* buffer, size_t length) {
   return -1;
 }
 
 bool CancelableSyncSocket::Shutdown() {
   return false;
 }
 
 // static
 bool CancelableSyncSocket::CreatePair(CancelableSyncSocket* socket_a,
                                       CancelableSyncSocket* socket_b) {
   return SyncSocket::CreatePair(socket_a, socket_b);
 }
 
 }  // namespace base