Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1570)

Unified Diff: base/sync_socket_nacl.cc

Issue 23875019: Add SyncSocket::ReceiveWithTimeout() and SyncSocket unit tests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix timeout and naming. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/sync_socket_nacl.cc
diff --git a/base/sync_socket_nacl.cc b/base/sync_socket_nacl.cc
index 7bab8840c0170a1247cf6bc1d383047b3447639e..fce6d56a6beb0096520f4c4aef3b879ce8e957e7 100644
--- a/base/sync_socket_nacl.cc
+++ b/base/sync_socket_nacl.cc
@@ -45,6 +45,10 @@ size_t SyncSocket::Receive(void* buffer, size_t length) {
return read(handle_, buffer, length);
}
+size_t SyncSocket::ReceiveWithTimeout(void* buffer, size_t length, TimeDelta) {
+ return -1;
jar (doing other things) 2013/10/14 15:31:07 Shouldn't this be return 0?
DaleCurtis 2013/10/14 19:25:13 I just copied the pattern, but probably all of the
+}
+
size_t SyncSocket::Peek() {
return -1;
}

Powered by Google App Engine
This is Rietveld 408576698