Improve speech contextual announcements and startCallback synchronization

Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when encountering whitespace as Google TTS appears to have been fixed. Note that this might not be the case on other platforms, but ChromeVox for Chrome OS works well.

BUG=652142, 619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are not played at the same time sounding like a big error tone). Context is uttered first when tab switching, menu navigating in panel/docs.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/65b61482831bb68bfc32db6d3f7f67df53584db2
Cr-Commit-Position: refs/heads/master@{#423774}

[David Tseng, 2016-10-04 16:53:58]

Description was changed from

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

m

BUG=
==========

to

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

m

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-04 16:56:41]

Description was changed from

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

m

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge
utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are
not played at the same time sounding like a big error tone).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-04 16:56:41]

dtseng@chromium.org changed reviewers:
+ dmazzoni@chromium.org

[David Tseng, 2016-10-04 16:57:11]

Description was changed from

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge
utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are
not played at the same time sounding like a big error tone).
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge
utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are
not played at the same time sounding like a big error tone). Context is uttered
first when tab switching, menu navigating in panel/docs.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[David Tseng, 2016-10-04 19:01:24]

The CQ bit was checked by dtseng@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-04 19:01:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dmazzoni, 2016-10-04 20:00:34]

lgtm

A refinement might be to output only the first
context that has outputContextFirst set.

For example when we open the panel menu, it
should announce the menu first, but not the
panel window.

https://codereview.chromium.org/2387413002/diff/20001/chrome/browser/resource...
File chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
(right):

https://codereview.chromium.org/2387413002/diff/20001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js:171:
dialog: {
How about outputContextFirst for dialog, alertdialog, and window too?

[commit-bot: I haz the power, 2016-10-04 20:23:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-04 20:23:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-10-04 23:30:39]

On Tue, Oct 4, 2016 at 1:00 PM, <dmazzoni@chromium.org> wrote:

> lgtm
>
> A refinement might be to output only the first
> context that has outputContextFirst set.
>
> For example when we open the panel menu, it
> should announce the menu first, but not the
> panel window.
>
> Noted.

>
>
> https://codereview.chromium.org/2387413002/diff/20001/
> chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
> File
> chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js
> (right):
>
> https://codereview.chromium.org/2387413002/diff/20001/
> chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js#
> newcode171
> chrome/browser/resources/chromeos/chromevox/cvox2/
> background/output.js:171:
> dialog: {
> How about outputContextFirst for dialog, alertdialog, and window too?
>
> https://codereview.chromium.org/2387413002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[David Tseng, 2016-10-04 23:36:27]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-04 23:36:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2387413002/#ps40001
(title: "Add more roles for context first")

[commit-bot: I haz the power, 2016-10-04 23:36:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 00:48:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 00:48:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-10-05 17:10:54]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-05 17:10:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2387413002/#ps60001
(title: "Fix tests.")

[commit-bot: I haz the power, 2016-10-05 17:11:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-05 17:57:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-05 17:57:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-10-06 19:10:59]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-06 19:11:00]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2387413002/#ps80001
(title: "Fix tts test.")

[commit-bot: I haz the power, 2016-10-06 19:11:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-06 20:14:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-06 20:14:15]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[David Tseng, 2016-10-06 23:30:29]

The CQ bit was checked by dtseng@chromium.org

[David Tseng, 2016-10-06 23:30:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
dmazzoni@chromium.org
Link to the patchset: https://codereview.chromium.org/2387413002/#ps100001
(title: "Disable test; it lonly works if you have Google tts installed
locally.")

[commit-bot: I haz the power, 2016-10-06 23:30:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-07 01:29:20]

Description was changed from

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge
utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are
not played at the same time sounding like a big error tone). Context is uttered
first when tab switching, menu navigating in panel/docs.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge
utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are
not played at the same time sounding like a big error tone). Context is uttered
first when tab switching, menu navigating in panel/docs.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[commit-bot: I haz the power, 2016-10-07 01:29:22]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-10-07 01:30:48]

Description was changed from

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge
utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are
not played at the same time sounding like a big error tone). Context is uttered
first when tab switching, menu navigating in panel/docs.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Improve speech contextual announcements and startCallback synchronization

- remove pref for reading context first and manually list roles for which it
makes sense to do this. In general, default to reading context last
- remove the workaround to manually callback start and end callbacks when
encountering whitespace as Google TTS appears to have been fixed. Note that this
might not be the case on other platforms, but ChromeVox for Chrome OS works
well.

BUG=652142,619279
TEST=continuous read over whitespace continues reading. In Google Groups, a huge
utterance (e.g. a div focused) results in proper sync of earcons (i.e. they are
not played at the same time sounding like a big error tone). Context is uttered
first when tab switching, menu navigating in panel/docs.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/65b61482831bb68bfc32db6d3f7f67df53584db2
Cr-Commit-Position: refs/heads/master@{#423774}
==========

[commit-bot: I haz the power, 2016-10-07 01:30:49]

Patchset 6 (id:??) landed as
https://crrev.com/65b61482831bb68bfc32db6d3f7f67df53584db2
Cr-Commit-Position: refs/heads/master@{#423774}