chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs - Issue 2387413002: Improve speech contextual announcements and startCallback synchronization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

Issue 2387413002: Improve speech contextual announcements and startCallback synchronization (Closed)

Patch Set: Disable test; it lonly works if you have Google tts installed locally. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | chrome/browser/resources/chromeos/chromevox/host/chrome/tts_background.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

index b84ab154b8f39fcde17d30ab4f28a09a7ee1e729..9fa6cf173bf85b7129e8d0cde245e098b2893b51 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output_test.extjs

@@ -100,6 +100,7 @@ OutputE2ETest.prototype = {

/** @override */

setUp: function() {

window.Dir = AutomationUtil.Dir;

+ this.forceContextualLastOutput();

}

};

@@ -491,9 +492,11 @@ TEST_F('OutputE2ETest', 'ListBox', function() {

SYNC_TEST_F('OutputE2ETest', 'MessageIdAndEarconValidity', function() {

for (var key in Output.ROLE_INFO_) {

var value = Output.ROLE_INFO_[key];

- Msgs.getMsg(value.msgId);

- Msgs.getMsg(value.msgId + '_brl');

- assertFalse(/[A-Z]+/.test(value.msgId));

+ if (value.msgId) {

+ Msgs.getMsg(value.msgId);

+ Msgs.getMsg(value.msgId + '_brl');

+ assertFalse(/[A-Z]+/.test(value.msgId));

+ }

if (value.earconId)

assertNotNullNorUndefined(cvox.Earcon[value.earconId]);

}