Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Issue 23874016: Always enable FCM on Windows Vista+. (Closed)

Created:
7 years, 3 months ago by gab
Modified:
7 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, joi+watch-content_chromium.org, piman+watch_chromium.org, jam, apatrick_chromium, darin-cc_chromium.org, cpu_(ooo_6.6-7.5)
Visibility:
Public.

Description

Always enable FCM on Windows Vista+. This is part 2/3 of re-landing https://codereview.chromium.org/22198004/. It will land before part 1/3 @ https://codereview.chromium.org/23534006 because this part is core to getting Aura on the waterfall and part 1/3 has already been blocking us for too long. We want to use the blacklist rather than hardcode OS versions in compositor_util, but for now hardcoding is fine... TBR=zmo BUG=233830, 267038 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221643

Patch Set 1 #

Patch Set 2 : actually hardcode Vista+... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -19 lines) Patch
M content/browser/gpu/compositor_util.cc View 1 4 chunks +23 lines, -18 lines 0 comments Download
A content/browser/gpu/compositor_util_browsertest.cc View 1 chunk +36 lines, -0 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
gab
Mo, committing this right away, discussed with cpu and although we don't want to be ...
7 years, 3 months ago (2013-09-05 23:34:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/23874016/1
7 years, 3 months ago (2013-09-05 23:35:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gab@chromium.org/23874016/5001
7 years, 3 months ago (2013-09-05 23:39:16 UTC) #3
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 08:21:19 UTC) #4
Message was sent while issue was closed.
Change committed as 221643

Powered by Google App Engine
This is Rietveld 408576698